Bug 7913 - Automatically receive serial issues
Summary: Automatically receive serial issues
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Koha Team University Lyon 3
QA Contact: Ian Walls
URL:
Keywords:
: 8153 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-04-06 03:36 UTC by Savitra Sirohi
Modified: 2014-05-26 21:04 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Receiving serials in a loop (4.17 KB, patch)
2012-05-22 14:32 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
multi_receiving_button (30.06 KB, image/png)
2012-05-22 14:43 UTC, Koha Team University Lyon 3
Details
Receiving serials in a loop (4.19 KB, patch)
2012-08-02 10:00 UTC, Paul Poulain
Details | Diff | Splinter Review
Follow-up, hide multi receive button for subs with items (3.43 KB, patch)
2012-09-20 13:19 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug_7913, Folllow-up hide button for subs with items (3.46 KB, patch)
2012-10-01 08:54 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Savitra Sirohi 2012-04-06 03:36:23 UTC
Currently in Koha, each issues is marked "arrived" manually. This can be a lot of work in libraries with a large number of serial subscriptions.

Instead, automatically mark issues as received. Issues that are not received will be marked "pending" manually. 

Create screens that display issues to be received across serials, set default to "arrived", user can select the ones that have not arrived and mark them as "pending".
Comment 1 Koha Team University Lyon 3 2012-05-22 14:32:52 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2012-05-22 14:43:31 UTC
Created attachment 9703 [details]
multi_receiving_button
Comment 3 Koha Team University Lyon 3 2012-05-22 14:57:05 UTC
I made some days ago for local use this patch which could be a response to what you asked for.
It adds in the Serial collection information page a button called 'Multi receiving' (may be we could find a more appropriate term). Clicking displays a message box from which you can enter the number of issues you'd like to receive. It generates theese in a loop, applying them the 'arrived' status and ends with an expected one. In case the end of subscription is reached before all the desired issues had been created, the script stops and let appear the usual 'subscription has expired' red message.
Comment 4 delaye 2012-06-21 12:29:43 UTC
the use of this function is limited to subscriptions without items records.And the bulk reception start always from the last issue expected then it would be better to choose which serial number you want to begin receiving and not always from the last number expected.
Comment 5 Savitra Sirohi 2012-06-21 12:43:59 UTC
When we created this bug, our intention was to create a way to automatically receive issues, no manual intervention. 

We will soon be submitting a patch which has a script that runs in the cron. Issues in expected status will be automatically changed to arrived.

Maybe this change and our change can co-exist.
Comment 6 Koha Team University Lyon 3 2012-07-06 10:38:38 UTC
(In reply to comment #0)
> Currently in Koha, each issues is marked "arrived" manually. This can be a
> lot of work in libraries with a large number of serial subscriptions.
> 
> Instead, automatically mark issues as received. Issues that are not received
> will be marked "pending" manually. 
> 
> Create screens that display issues to be received across serials, set
> default to "arrived", user can select the ones that have not arrived and
> mark them as "pending".

(In reply to comment #4)
> the use of this function is limited to subscriptions without items
> records.And the bulk reception start always from the last issue expected
> then it would be better to choose which serial number you want to begin
> receiving and not always from the last number expected.

As for receiving from the last issue expected, I must add that this has been made
thinking to the case when library is closed during some weeks (well, french university libraries close completly during 2 or 3 weeks in summer holidays). So when you come back from holidays, you can quickly and in a much easier way receive your waiting bunch of issues.
Comment 7 Paul Poulain 2012-08-02 10:00:12 UTC
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Comment 8 Paul Poulain 2012-08-02 10:00:35 UTC
Created attachment 11291 [details] [review]
Receiving serials in a loop

generate the number of issues entered from a message box and apply
'arrived' status.

http://bugs.koha-community.org/show_bug.cgi?id=7913
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Comment 9 Mason James 2012-09-16 11:24:24 UTC
> Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit ce03893)
 * 551e5b2 Receiving serials in a loop
      koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
      serials/serials-collection.pl

* serials/serials-collection.pl                                            OK
* koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt    OK
Comment 10 Paul Poulain 2012-09-17 17:34:25 UTC
QA comment:
 * Stéphane, in comment 4 you say:
> the use of this function is limited to subscriptions without items
> records.And the bulk reception start always from the last issue expected
> then it would be better to choose which serial number you want to begin
> receiving and not always from the last number expected.

it seems it's still the case, this is a reason for failing QA : libraries won't know or will make a mistake, for sure ! To earn QA, this patch should hide the link when the subscrition.serialsadditems=1

Optional suggestion (that isn't requested to pass QA) = have the link/feature also available from serials/serials-edit.pl page

Other than this, it's a very handy feature !
Comment 11 Paul Poulain 2012-09-17 17:35:31 UTC
Koha team Lyon 3, if you provide a follow-up, please attach the follow-up, and switch back to passed QA, i'll test/check and push if everything is OK with the follow-up

I've checked the main patch, works nicely.
Comment 12 Koha Team University Lyon 3 2012-09-20 13:19:21 UTC Comment hidden (obsolete)
Comment 13 Paul Poulain 2012-09-28 13:59:28 UTC
Sorry, but the follow-up does not apply :
Applying: Follow-up, hide multi button for subs with item
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Follow-up, hide multi button for subs with item
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 14 Koha Team University Lyon 3 2012-10-01 08:54:06 UTC
Created attachment 12615 [details] [review]
Bug_7913, Folllow-up hide button for subs with items

redone on master (instead of 3.8).
Comment 15 Paul Poulain 2012-10-01 15:52:43 UTC
Patch pushed to master
Comment 16 Jared Camins-Esakov 2013-01-02 02:45:34 UTC
*** Bug 8153 has been marked as a duplicate of this bug. ***