Bug 7944 - attribute error could be clearer
Summary: attribute error could be clearer
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 18:10 UTC by Nicole C. Engard
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
attribute error (151.15 KB, image/jpeg)
2012-04-11 18:10 UTC, Nicole C. Engard
Details
Bug 7944 - attribute error could be clearer (2.97 KB, patch)
2014-07-18 18:28 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 7944 - attribute error could be clearer (3.00 KB, patch)
2014-08-08 21:43 UTC, Christopher Brannon
Details | Diff | Splinter Review
[PASSED QA] Bug 7944 - attribute error could be clearer (3.15 KB, patch)
2014-08-10 21:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-04-11 18:10:53 UTC
Created attachment 9125 [details]
attribute error

When you have an attribute set to unique you get an error when trying to save the patron record, but it mentions an attribute number and that number is not visible anywhere in the staff client so it's confusing the librarian entering the data what field they entered the wrong info in to.

See attached (ignore the circled fields - the Driver's License is the unique field here.
Comment 1 Owen Leonard 2014-07-18 18:28:03 UTC Comment hidden (obsolete)
Comment 2 Christopher Brannon 2014-08-08 21:43:58 UTC Comment hidden (obsolete)
Comment 3 Christopher Brannon 2014-08-08 21:47:02 UTC
Master shows differently than example, where the CODE of the attribute is given, but still it is unclear.  Patch is a HUGE improvement.  Thanks for the patch!

Christopher
Comment 4 Katrin Fischer 2014-08-10 21:12:31 UTC
Created attachment 30667 [details] [review]
[PASSED QA] Bug 7944 - attribute error could be clearer

If you try to create a patron and enter an extended attribute value
which is required to be unique but exists in another record the error
you receive is not clear. It uses the attribute code instead of the
description. This patch adds description to the output.

To test you must have ExtendedPatronAttributes enabled.

- Edit or create an extended patron attribute and designate it a unique
  identifier.
- Edit a patron and add a value to that attribute.
- Edit another patron and try to add the same value.

You should get an error which includes both the description of the
attribute you tried to modify and the value you submitted.

Signed-off-by: Christopher Brannon <christopher@debian.brannon.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Passes tests and Qa script.
Comment 5 Tomás Cohen Arazi 2014-08-11 18:56:36 UTC
Patch pushed to master.

Thanks Owen!