Bug 7951 - Suspending holds needs a system preference
Summary: Suspending holds needs a system preference
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Ian Walls
QA Contact: Ian Walls
URL:
Keywords:
Depends on: 7641
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-12 18:52 UTC by Katrin Fischer
Modified: 2013-12-05 20:01 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7951 - Suspending holds needs a system preference (11.32 KB, patch)
2012-04-13 15:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 7951 - Suspending holds needs a system preference (11.25 KB, patch)
2012-05-14 13:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 7951 - Suspending holds needs a system preference (11.54 KB, patch)
2012-06-02 07:40 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-04-12 18:52:43 UTC
The new feature to suspend holds needs to be controlled by a system preference to turn it off. Ideally 2 system preferences, one for OPAC and one for staff.

As a workaround for the pending 3.8 release we should put in id's - so the feature can be hidden from the display using jquery.
Comment 1 Kyle M Hall 2012-04-13 15:13:12 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-04-15 06:52:08 UTC
Hi Kyle, 
thx for implementing the system preferences. I tried testing your patch but have a conflict I can't resolve:

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 7951 - Suspending holds needs a system preference
/home/katrin/kohaclone/.git/rebase-apply/patch:207: trailing whitespace.
$template->param( 
/home/katrin/kohaclone/.git/rebase-apply/patch:223: trailing whitespace.
$template->param( 
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 7951 - Suspending holds needs a system preference
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Could you please check what's going wrong and resubmit? Thx!
Comment 3 Kyle M Hall 2012-04-17 12:32:59 UTC
This bug depends on bug 7641, did you apply that patch first?
Comment 4 Jared Camins-Esakov 2012-05-13 11:18:32 UTC
Even with the patch for 7641, this patch will not apply.
Comment 5 Kyle M Hall 2012-05-14 13:21:09 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2012-06-02 07:40:02 UTC
Created attachment 9900 [details] [review]
Bug 7951 - Suspending holds needs a system preference

Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 7 Paul Poulain 2012-06-09 16:50:10 UTC
QA comment:
 * small patch that improves a recently added feature
 * does that in the most logical way
 * nothing to say from coding guidelines POV

passed QA
Comment 8 Chris Cormack 2012-06-10 09:59:21 UTC
The suspend holds functionality is already in 3.8.x but no way to turn it on our off, this implements that. So I am counting more as a bug fix. Pushed to 3.8.x will be in 3.8.2