The new feature to suspend holds needs to be controlled by a system preference to turn it off. Ideally 2 system preferences, one for OPAC and one for staff. As a workaround for the pending 3.8 release we should put in id's - so the feature can be hidden from the display using jquery.
Created attachment 9179 [details] [review] Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac.
Hi Kyle, thx for implementing the system preferences. I tried testing your patch but have a conflict I can't resolve: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7951 - Suspending holds needs a system preference /home/katrin/kohaclone/.git/rebase-apply/patch:207: trailing whitespace. $template->param( /home/katrin/kohaclone/.git/rebase-apply/patch:223: trailing whitespace. $template->param( fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7951 - Suspending holds needs a system preference When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Could you please check what's going wrong and resubmit? Thx!
This bug depends on bug 7641, did you apply that patch first?
Even with the patch for 7641, this patch will not apply.
Created attachment 9563 [details] [review] Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac.
Created attachment 9900 [details] [review] Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment: * small patch that improves a recently added feature * does that in the most logical way * nothing to say from coding guidelines POV passed QA
The suspend holds functionality is already in 3.8.x but no way to turn it on our off, this implements that. So I am counting more as a bug fix. Pushed to 3.8.x will be in 3.8.2