Bug 7954 - Errors in kohastructure.sql
Summary: Errors in kohastructure.sql
Status: CLOSED DUPLICATE of bug 5668
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P1 - high major (vote)
Assignee: Julian Maurice
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 09:37 UTC by Julian Maurice
Modified: 2012-10-26 00:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
fix kohastructure.sql (1.81 KB, patch)
2012-04-13 09:40 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2012-04-13 09:37:52 UTC
I just made a fresh master installation, and encountering the following error:

ERROR 1064 (42000) at line 2821: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-
    biblionumber int(11) NOT NULL, -
    rating_value tinyint(1) NOT NULL, -
 '

It seems that in '---', only the two last dashes are considered by MySQL as the start of a comment.

$mysql -V
mysql  Ver 14.14 Distrib 5.1.61, for debian-linux-gnu (x86_64) using readline 6.2
Comment 1 Katrin Fischer 2012-04-13 09:39:34 UTC
Hi Julian, there is a patch for this waiting for qa :)

bug 5668

*** This bug has been marked as a duplicate of bug 5668 ***
Comment 2 Julian Maurice 2012-04-13 09:40:38 UTC
Created attachment 9172 [details] [review]
fix kohastructure.sql

Replace '---' by '--' as MySQL seems to consider only the two last
dashes as the start of a comment.
Also add a missing 'DROP TABLE IF EXISTS' before 'CREATE TABLE'
Comment 3 Julian Maurice 2012-04-13 09:41:37 UTC
oh... ok :-) Thanks Katrin.