Bug 7959 - Update OPAC suggestions interface to match lists
Summary: Update OPAC suggestions interface to match lists
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.10
Hardware: All All
: P3 enhancement (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 19:20 UTC by Owen Leonard
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7959 - Update OPAC suggestions interface to match lists (5.92 KB, patch)
2012-04-13 19:28 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7953 - add opacuserjs to the sco template (1.51 KB, patch)
2012-04-30 13:29 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7959 - Update OPAC suggestions interface to match lists (5.95 KB, patch)
2012-05-08 13:01 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 7959 - Update OPAC suggestions interface to match lists (5.93 KB, patch)
2012-05-22 17:32 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-04-13 19:20:29 UTC
The OPAC's suggestions list is similar to that of lists in that there is an action you can take directly (new suggestion) and an action you can take if items are selected (delete suggestion). The "toolbar" should match the one on lists in that the delete option should only be available if an item is selected.
Comment 1 Owen Leonard 2012-04-13 19:28:18 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-04-30 13:29:08 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2012-04-30 13:31:16 UTC
Sorry, git bz typo.
Comment 4 Nicole C. Engard 2012-05-08 13:01:16 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2012-05-10 14:20:32 UTC
Hi Owen,

Is there a reason to use double quote instead of simple quote in your html replacement ?

I think:

  $("span.checkall").html("<a id=\"CheckAll\" href=\"#\">"+_('Select all')+"<\/a>");

is not easier to read than:

  $("span.checkall").html('<a id="CheckAll" href="#">'+_('Select all')+'</a>');
Comment 6 Owen Leonard 2012-05-10 18:48:49 UTC
(In reply to comment #5)
> Is there a reason to use double quote instead of simple quote in your html
> replacement ?

I agree about the readability, but I also like the consistency of always using a double quote when I start typing something like .html() knowing that I can escape any quotes I'll need later.

I'd be happy to agree to either pattern and set a coding guideline for it.
Comment 7 Paul Poulain 2012-05-22 10:00:45 UTC
The patch does not apply, 
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt

I feel it's not hard to fix, but I don't want to do a mistake, so please rebase & resubmit
Comment 8 Owen Leonard 2012-05-22 17:32:44 UTC
Created attachment 9708 [details] [review]
Bug 7959 - Update OPAC suggestions interface to match lists

Rebased against current master
Comment 9 Paul Poulain 2012-05-28 14:08:35 UTC
QA comment: template change only, passes tests for validity/translatability

passed QA
Comment 10 Jared Camins-Esakov 2012-12-31 01:02:38 UTC
There have been no further reports of problems so I am marking this bug resolved.