Bug 7967 - Z39.50 client should negotiate encoding with server
Summary: Z39.50 client should negotiate encoding with server
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: rel_3_2
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pongtawat
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-16 05:53 UTC by Pongtawat
Modified: 2023-08-04 19:55 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add UTF-8 charset negotiation to Z39.50 search (671 bytes, patch)
2012-04-16 05:53 UTC, Pongtawat
Details | Diff | Splinter Review
Bug 7967 - set charset when doing Z39.50 search (1.10 KB, patch)
2012-04-17 09:02 UTC, Chris Cormack
Details | Diff | Splinter Review
set charste for Z39.50 in acquision (647 bytes, patch)
2012-04-19 04:19 UTC, Pongtawat
Details | Diff | Splinter Review
Bug 7967 : Followup set encoding options for acqui/z3950_search.pl (961 bytes, patch)
2012-05-20 09:37 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pongtawat 2012-04-16 05:53:15 UTC Comment hidden (obsolete)
Comment 1 Chris Cormack 2012-04-17 09:02:22 UTC
Created attachment 9222 [details] [review]
Bug 7967 - set charset when doing Z39.50 search

Original patch from Pongtawat
Comment 2 Pongtawat 2012-04-19 04:19:33 UTC Comment hidden (obsolete)
Comment 3 Pongtawat 2012-04-19 04:20:59 UTC
I just notice that there is another Z39.50 client code in acquision that should also be updated (acqui/z3950_search.pl). I think it should be included in the patch (but I don't know how).
Comment 4 Chris Cormack 2012-05-20 09:37:12 UTC
Created attachment 9667 [details] [review]
Bug 7967 : Followup set encoding options for acqui/z3950_search.pl
Comment 5 Owen Leonard 2012-08-07 13:11:33 UTC
Can we get a test plan for this?
Comment 6 Magnus Enger 2013-01-27 12:10:48 UTC
The code that these patches touched has been moved to C4::Breeding (and concolidated into a single function) by bug 9105.
Comment 7 Pongtawat 2013-02-13 09:37:08 UTC
I just found that setting this charset option broke some Z39.50 servers. For example, for OhioLink server, it will freeze. Horizon Z39.50 server here seem to not like it either. So, it shouldn't be set unless needed.

Since I need to set this option for OCLC to work properly for Thai language, so locally, I just hacked it to have a new option "UTF-8 with negotiation" to do this. 

Since it seems no one else has this problem, maybe the code should be leave as-is and this bug closed?
Comment 8 Katrin Fischer 2023-08-04 19:55:47 UTC
(In reply to Pongtawat from comment #7)
> 
> Since it seems no one else has this problem, maybe the code should be leave
> as-is and this bug closed?

This is the last comment from 2013. I'll close as WONTFIX.