upload_local_cover_images - is missing completely from installer/data/mysql/nb-NO/mandatory/userpermissions.sql - for de-DE it needs to be translated.
Created attachment 9261 [details] [review] Bug 7984 - Fix the upload_local_cover_images permission upload_local_cover_images is needed to use the new, cool local covers feature This patch - adds upload_local_cover_images to installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql from whch it was missing, making it impossible to use the local covers feature in an nb-NO installation - translates the text of the preference for de-DE (thanks to cait, drojf and mveron for the translation)
To test: Hm, guess the proper way to do it is - install de-DE and nb-NO - run through the web installer on an empty database for each of the languages and check that the local cover image feature can be used
Created attachment 9339 [details] [review] Bug 7984 - Fix the upload_local_cover_images permission upload_local_cover_images is needed to use the new, cool local covers feature This patch - adds upload_local_cover_images to installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql from whch it was missing, making it impossible to use the local covers feature in an nb-NO installation - translates the text of the preference for de-DE (thanks to cait, drojf and mveron for the translation) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 9340 [details] [review] Bug 7984 - Fix the upload_local_cover_images permission upload_local_cover_images is needed to use the new, cool local covers feature This patch - adds upload_local_cover_images to installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql and installer/data/mysql/es-ES/mandatory/userpermissions.sql from whch it was missing, making it impossible to use the local covers feature in an nb-NO or es-ES installation - translates the text of the preference for de-DE (thanks to cait, drojf and mveron for the translation) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Uploaded the wrong file before, sorry.
Created attachment 9341 [details] [review] Bug 7984 [SIGNED-OFF] - Fix the upload_local_cover_images permission upload_local_cover_images is needed to use the new, cool local covers feature This patch - adds upload_local_cover_images to installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql from whch it was missing, making it impossible to use the local covers feature in an nb-NO installation - translates the text of the preference for de-DE (thanks to cait, drojf and mveron for the translation) Signed-off-by: Marc Veron <veron@veron.ch> I did no fresh installs, however I - had a look at the files before and after applying the patch - carefully checked the syntax - tested with MySQL by removing the entry in the table 'permissions' double checked that now the entry in Staff client was one and then did an insert with the sql snippets. In DE-de the translated entry translation appeared as expected.
Oh, we did the same at almost the same time :-)
Attachment 9340 [details] from Jared added the permission to the es-ES file, which I had missed. Attachment 9341 [details] from Marc does not have this, so I think 9340 is the one that should get QA'ed?
Comment on attachment 9340 [details] [review] Bug 7984 - Fix the upload_local_cover_images permission Un-obsoleting attachment 9340 [details] [review] - see my previous comment.
Just adds permission to nb-NO, and updates for de-DE. Simple enough. Marking Passed QA.
Comment on attachment 9340 [details] [review] Bug 7984 - Fix the upload_local_cover_images permission patch also signed-off by marc
This will be in 3.8.1