Display in a holding summary tab informations about serial record branch (955$9) holding summary (955$r) call (930$a) Informations imported from SUDOC example : http://catalogue.univ-aix-marseille.fr/cgi-bin/koha/opac-detail.pl?biblionumber=725747
Created attachment 9400 [details] [review] Bug 7991: Add itemcallnumber into the serial collection tab This patch adds a new column containing the itemcallnumber value into the serial collection tab (opac detail).
Hmm is this UNIMARC specific ? Because for MARC21 isn't the itemcallnumber in 952?
after testing in a sandbox :its ok for me with the Unimarc. if we must apply this patch for the marc21 the fields are : UNIMARC MARC 21 callnumber -> 930$a 852$h location -> 955$9 852$a$b and sub location holding summary 955$r 863 (main collection),864 (suppl),865 (index)
Created attachment 10406 [details] [review] Bug 7991: Add itemcallnumber into the serial collection tab This patch adds a new column containing the itemcallnumber value into the serial collection tab (opac detail). 930$a for UNIMARC 852$h for others
Created attachment 11553 [details] [review] Bug 7991: Add itemcallnumber into the serial collection tab This patch adds a new column containing the itemcallnumber value into the serial collection tab (opac detail). 930$a for UNIMARC 852$h for others Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> (Added Stephane Delaye's sign off at the same time as mine) As this view has never worked with MARC21, I am comfortable signing off on the fact that the patch does not in any way impact the MARC21 display.
QA comment: tiny patch, passes perlcritic & koha-qa.pl MARC21 comment(s): * Jared, what do you mean by: > As this view has never worked with MARC21, I am comfortable signing > off on the fact that the patch does not in any way impact the MARC21 > display. * Looking at the patch, I see something is added, I see: + $row_data{itemcallnumber} = $marcflavour eq 'UNIMARC' + ? $lc_field->subfield('a') # 930$a + : $lc_field->subfield('h') # 852$h + if ($sc_field->subfield('5') eq $lc_field->subfield('5')); In MARC21, there is no $5 field, so I think this code does nothing for MARC21 As Jared says this tab does not work at all, I'm marking passed QA, but I'd like to make this tab working for MARC21 too.
Patch pushed to master I consider this is an enhancement, so for 3.10 only. It's a tiny patch that can be reverted if it appears there's a real problem for MARC21