8005 – Lost item is not anonymized when checked in

Bug 8005 - Lost item is not anonymized when checked in

Summary: Lost item is not anonymized when checked in

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Circulation (show other bugs)
Version:	3.6
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Kyle M Hall
QA Contact:	Ian Walls

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-04-24 22:00 UTC by Joy Nelson
Modified:	2013-12-05 19:59 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8005 - Lost item is not anonymized when checked in (2.26 KB, patch) 2012-04-25 12:36 UTC, Kyle M Hall	Details \| Diff \| Splinter Review
Bug 8005 - Lost item is not anonymized when checked in (2.36 KB, patch) 2012-06-09 11:14 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joy Nelson 2012-04-24 22:00:33 UTC

When an item is marked as lost and then later checked in, the circulation history is not anonymized, i.e. the patron who 'lost' it, is still shown as the last person to check out the item.

Comment 1 Kyle M Hall 2012-04-25 12:36:45 UTC Comment hidden (obsolete)

Created attachment 9293 [details] [review]
Bug 8005 - Lost item is not anonymized when checked in

This bug is caused by the subroutine C4::Circulation::LostItem
not passing the privacy parameter when calling
C4::Circulation::MarkIssueReturned.

This issue is actually anonymized when the item is marked as lost,
not when the item is checked in.

Note, even if the issue is anonymized, the fine charged for lost
items still contains a description of the lost item, which is
required for the ability to forgive fees for lost items that
are later found.

Comment 2 Martin Renvoize (ashimema) 2012-06-09 11:14:57 UTC

Created attachment 10013 [details] [review]
Bug 8005 - Lost item is not anonymized when checked in

Comment 3 Paul Poulain 2012-06-10 10:35:55 UTC

QA comment: small patch, using a sub (GetMemberDetails) that is an heavy one, but using it quite unfrequentely, so it's OK. Other than this, only 3 lines added, passed QA

Comment 4 Paul Poulain 2012-06-10 10:38:15 UTC

Side question: in ReturnLostItem, we use the same sub:
MarkIssueReturned( $borrowernumber, $itemnum );

shouldn't we also add ->privacy parameter ?

Comment 5 Chris Cormack 2012-07-13 01:57:23 UTC

This is in 3.8.x