On boraccount.pl, if an itemnumber is present in the accountline, the script passes ->{title} into the template for display (in GetMemberAccountRecords). The template for pay.pl tries to use a ->{title} entry in the same way to help populate the "Description" field, but GetBorNotifyAcctRecord doesn't create that, so only accountlines.description (if present) shows up. Patch coming shortly.
Created attachment 9295 [details] [review] Proposed patch
Created attachment 9535 [details] [review] Bug 8009: Item descriptive data not populated on pay.pl GetBorNotifyAcctRecord was not populating the {title} element of the hash, which pay.tt will use. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA Comments: I don't find where is used the biblionumber, maybe it is useless. I think it is better to separate the description and the title, at least with a dot. I will propose a followup
Created attachment 9585 [details] [review] Bug 8009: Followup Item descriptive data not populated on pay.pl
Created attachment 9592 [details] [review] Bug 8009: Followup Item descriptive data not populated on pay.pl Separation of title from the description. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
First patch just adds new params to export; marking Passed QA Second patch is just a set of () in a template... passed QA as well
more an ENH than a fix I think
Fix or enhancement, I'd really like to see it in Stable, if that's possible. We've got several libraries that are asking for it.
I would consider this a bugfix. I intend to backport to 3.6.x, as it is a low-risk patch that fixes an obvious error.
Just weighing in on this issue, “from the field” (Preston Library at VMI). We’re an academic library whose faculty have a loan period of a whole academic year. All their books are due on April 15, and when they are not returned after 28 days, they all become “Billed”. It would not be too unusual for a faculty member to want to pay for one item from a list of other billed items that he expects to return in a few days. You can imagine in that case how hard it would be to receive payment for the correct item, since there is no description on the “Pay Fines” tab. So, to me, this seems more like a fix than an enhancement, and it would be great to have it fixed as soon as possible.
Pushed to 3.8.x .. I will personally ring everyone of you if anyone complains about it being in 3.8.2 :-)