On the patron entry form I think it would be clearer if the "restricted until" form field was hidden if "Restricted: No" is checked. This remove any ambiguity about whether the field can or should be filled in independently of the "Restricted" options.
Created attachment 9312 [details] [review] Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked This patch adds JavaScript to automatically hide the "Restricted unil" form field on the patron entry form if "Restricted: No" is selected. If "Restricted: Yes" is chosen the "Until:" field is shown and focus is given to it. The patch also adds a note, "(optional)" after the "Until:" field to make it clearer that a date is not required. To test, open a patron record and try moving the selection between "Restricted: No" and "Restricted: Yes." Confirm that the "Until:" field is shown and hidden as expected. Confirm that the restricted flag is correctly set or unset upon save, including setting the flag with or without a date.
Created attachment 9534 [details] [review] Bug 8014 - On the patron entry form hide "restricted until" field if "Restricted: No" is checked This patch adds JavaScript to automatically hide the "Restricted unil" form field on the patron entry form if "Restricted: No" is selected. If "Restricted: Yes" is chosen the "Until:" field is shown and focus is given to it. The patch also adds a note, "(optional)" after the "Until:" field to make it clearer that a date is not required. To test, open a patron record and try moving the selection between "Restricted: No" and "Restricted: Yes." Confirm that the "Until:" field is shown and hidden as expected. Confirm that the restricted flag is correctly set or unset upon save, including setting the flag with or without a date. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA Comment : tiny patch, js and tt only, nothing specific to say passed QA
pushed, usefull for 3.8 I think, so versionning 3.8
I agree useful for for 3.8.x, will be in 3.8.2