Bug 8079 - opac not showing fines - says 'no'
Summary: opac not showing fines - says 'no'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
: 5688 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-11 18:25 UTC by Nicole C. Engard
Modified: 2014-05-26 21:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
staff shows fines (45.50 KB, image/png)
2012-05-11 18:25 UTC, Nicole C. Engard
Details
opac says no (49.06 KB, image/png)
2012-05-11 18:25 UTC, Nicole C. Engard
Details
Bug 8079 - opac not showing fines - says 'no' (1.13 KB, patch)
2013-02-12 15:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 8079 - opac not showing fines - says 'no' (1.42 KB, patch)
2013-02-15 06:47 UTC, David Cook
Details | Diff | Splinter Review
[PASSED QA] Bug 8079 - opac not showing fines - says 'no' (1.57 KB, patch)
2013-02-17 20:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-05-11 18:25:29 UTC
Created attachment 9524 [details]
staff shows fines

In the OPAC under the fines column on the 'checked out' tab it always says 'No'  See attached. In the staff client there are fines on the items, but in the OPAC it says 'No'.
Comment 1 Nicole C. Engard 2012-05-11 18:25:45 UTC
Created attachment 9525 [details]
opac says no
Comment 2 Kyle M Hall (khall) 2013-02-12 15:54:12 UTC
It appears that only charges of the types F and L are counted, but not FU.
Comment 3 Kyle M Hall (khall) 2013-02-12 15:56:22 UTC Comment hidden (obsolete)
Comment 4 David Cook 2013-02-15 06:47:12 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall (khall) 2013-02-15 13:52:39 UTC
Just so you know, FU is the fee code for a fine currently accruing ( you cannot pay off fines still accruing iirc ). When the item is returned, the code is switched to F. A lost item fee has a code of L.

Kyle

(In reply to comment #4)
> Created attachment 15333 [details] [review] [review]
> Bug 8079 - opac not showing fines - says 'no'
> 
> Make charges of type FU be counted for opac-user.pl
> 
> Test Plan:
> 1) Checkout an item to a patron, back date the date due enough to create
> fines
> 2) Run fines.pl
> 3) Log into the patron's account via the OPAC
> 4) Note the fines line for that issue says 'No'
> 5) Apply patch
> 6) Reload opac-user.pl, not the fines column now says 'Yes'
> 
> Signed-off-by: David Cook <dcook@prosentient.com.au>
> 
> Works great, Kyle. Seeing as my test patron had $4500 in fines for that
> item, I was glad to see that column switch to "Yes" ;).
> 
> I'm not sure what the difference is between FU and F is, or what L means,
> but the patch works, so I'm signing off.
Comment 6 Nicole C. Engard 2013-02-16 13:50:26 UTC
(In reply to comment #5)
> Just so you know, FU is the fee code for a fine currently accruing ( you
> cannot pay off fines still accruing iirc ). When the item is returned, the
> code is switched to F. A lost item fee has a code of L.

Yes you can pay a fine in FU - and always have been able to - something a lot of libraries like :)
Comment 7 Katrin Fischer 2013-02-17 20:41:49 UTC
*** Bug 5688 has been marked as a duplicate of this bug. ***
Comment 8 Katrin Fischer 2013-02-17 20:44:36 UTC
Created attachment 15481 [details] [review]
[PASSED QA] Bug 8079 - opac not showing fines - says 'no'

Make charges of type FU be counted for opac-user.pl

Test Plan:
1) Checkout an item to a patron, back date the date due enough to create fines
2) Run fines.pl
3) Log into the patron's account via the OPAC
4) Note the fines line for that issue says 'No'
5) Apply patch
6) Reload opac-user.pl, not the fines column now says 'Yes'

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works great, Kyle. Seeing as my test patron had $4500 in fines for that item, I was glad to see that column switch to "Yes" ;).

I'm not sure what the difference is between FU and F is, or what L means, but the patch works, so I'm signing off.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described, all tests and QA script are ok.
Note: why show yes and not the fine amount?
Comment 9 Jared Camins-Esakov 2013-02-20 13:16:45 UTC
This patch has been pushed to master.
Comment 10 Chris Cormack 2013-02-21 05:36:40 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10