Bug 8082 - The: IssuingInProcess configuration setting is working in reverse.
Summary: The: IssuingInProcess configuration setting is working in reverse.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: PC All
: P5 - low major (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-14 00:26 UTC by Joann Ransom
Modified: 2013-12-05 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess (1.14 KB, patch)
2012-05-14 01:49 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess (1.27 KB, patch)
2012-05-31 20:01 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Joann Ransom 2012-05-14 00:26:37 UTC
In the system preferences it is possible to nominate a $ value limit using a couple of confurable settings: maxoutstanding ang noissuescgarge  

A further system preference (IssuingInProcess) can be set to prevent / not prevent issues in a single session from being blocked if that threshold is reached.

For example: Koha Patrons have  $5 limit on their account. Patrons often borrow more than that in one transaction/session. So a transaction/session may be carried out to completion even if the amount owed goes over $5. They will however be blocked from any new borrowing until that debt is reduced below $5.

If the IssuingInProcess is set to <Prevent> it, illogically, doesn't prevent - and vice versa. It is working backwards.
Comment 1 Chris Cormack 2012-05-14 01:45:51 UTC
Yep at some point the description was changed

It is still right in the database

| IssuingInProcess           | 1     | NULL    | If ON, disables fines if the patron is issuing item that accumulate debt | YesNo |

Yes = On  ... but now
Prevent = On

So if switch prevent on, it does the checks about being in process and lets the issue proceed if it is in process.

So it is backwards.

Easiest fix is to fix the circulation.pref file, so the description matches reality.

Patch forthcoming
Comment 2 Chris Cormack 2012-05-14 01:49:26 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2012-05-14 01:50:16 UTC
.pref file text now matches reality

 if ( C4::Context->preference("IssuingInProcess") ) {
Comment 4 Liz Rea 2012-05-31 20:01:07 UTC
Created attachment 9866 [details] [review]
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, changes are as advertised.
Comment 5 Ian Walls 2012-06-04 16:56:19 UTC
Reverses language on the syspref file.  Marking Passed QA.
Comment 6 Chris Cormack 2012-06-05 19:44:26 UTC
Pushed to 3.8.x, will be in 3.8.2