Created attachment 9597 [details] card number twice Why is the card number showing twice on the patron search results? We really only need it once - either in it's own column or in parens. Twice is confusing.
Display of the patron name and card number in the second column is handled by an include, patron-title.inc, which offers a way to display the patron name in a standard format in various places in the templates. We can't remove the display of the barcode in the second column without affecting other displays too. The card number in the first column seems useful since it's easier to scan down the column if you're looking for a number. And hopefully someday we'll have AJAX-driven DataTables support on this page and we'll be able to sort by card number. I'm inclined to say "wontfix" since there are good reasons to have the number in both places. What do others think?
The question I keep getting is - what is that second number in parens. It's hard enough to get people to understand the difference between borrowernumber and the cardnumber - showing two numbers on this results page is confusing people already. Obviously I'll go with the masses, but I wanted you all to know this comment isn't coming from me (but I do agree with it) it's coming from librarians seeing Koha 3.8. Nicole
Still valid in the new patron search.
Created attachment 33604 [details] [review] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places.
Hi Marc, Please convince me why the change below should be correct: - ([% cardnumber -%]) + [% IF ( borrower.cardnumber ) %] + ([% borrower.cardnumber %]) + [% END %] It was prefixed without borrower and now it is. You do only change templates.
Hi Marcel, I will not even try to convince you, I simply mistaked. Patch with corrections follows. Groetjes Marc
Created attachment 33626 [details] [review] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places.
Patch still applies with current master.
Created attachment 34608 [details] [review] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris <chris@bigballofwax.co.nz>
Created attachment 34721 [details] [review] [PASSED QA] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=8096 Signed-off-by: Chris <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.3