Bug 8116 - z3950 empty search causes silent warning in koha-error_log
Summary: z3950 empty search causes silent warning in koha-error_log
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-18 07:56 UTC by Piotr Kowalski
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (489 bytes, text/plain)
2012-05-18 07:56 UTC, Piotr Kowalski
Details
Bug 8116 : Fixing warn in error log (717 bytes, patch)
2012-05-28 09:52 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kowalski 2012-05-18 07:56:24 UTC
Created attachment 9633 [details]
proposed patch

When searching z3950 with empty parameter list a silent warning occurs in koha-error_log:
z3950_search.pl: Use of uninitialized value in subroutine entry at /usr/lib/perl5/ZOOM.pm line 491

The reason is unassigned value in variable $query in line 118 of z3950_search.pl module.
The bug occurs also in earlier Koha version (3.6)
Comment 1 Chris Cormack 2012-05-28 09:52:02 UTC
Created attachment 9800 [details] [review]
Bug 8116 : Fixing warn in error log

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 2 Ian Walls 2012-06-04 16:46:31 UTC
Adds a default value of empty string to $query; marking Passed QA.
Comment 3 Paul Poulain 2012-06-05 13:56:00 UTC
Patch pushed, welcome to our 183th contributor ! ( Piotr, it's you ;-) )
Comment 4 Chris Cormack 2012-06-05 15:45:16 UTC
Pushed to 3.8.x, will be in 3.8.2