Bug 8119 - Show hint when disabling active currency checkbox
Summary: Show hint when disabling active currency checkbox
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/admin/currency.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-18 13:18 UTC by Owen Leonard
Modified: 2013-12-05 19:59 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8119 - Show hint when disabling active currency checkbox (1.40 KB, patch)
2012-05-18 13:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8119 - Show hint when disabling active currency checkbox (1.42 KB, patch)
2012-05-19 09:56 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8119 - Followup: Show hint when disabling active currency checkbox (1.78 KB, patch)
2012-05-22 09:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8119 - Show hint when disabling active currency checkbox (1.49 KB, patch)
2012-06-05 17:17 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8119 - Followup Show hint when disabling active currency checkbox (1.83 KB, patch)
2012-06-05 17:17 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-05-18 13:18:40 UTC
If you add or edit a currency with an exchange rate other than "1.0" the "active" checkbox is disabled, but the interface does not explain why. It would be nice to have a hint by the input explaining why it is disabled.
Comment 1 Owen Leonard 2012-05-18 13:21:02 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-05-19 09:56:13 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-05-22 09:38:16 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-06-05 17:17:27 UTC
Created attachment 9927 [details] [review]
Bug 8119 - Show hint when disabling active currency checkbox

Display a hint when the exchange rate != 1.0: "The active currency
must have a rate of 1.0"

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Comment 5 Jared Camins-Esakov 2012-06-05 17:17:57 UTC
Created attachment 9928 [details] [review]
Bug 8119 - Followup Show hint when disabling active currency checkbox

Display the message on editing

Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Comment 6 Jared Camins-Esakov 2012-06-05 17:20:07 UTC
Signed off by Shari Perkins, uploaded with Jared Camins-Esakov's account.
Comment 7 Ian Walls 2012-06-08 18:41:45 UTC
Both patches are javascript-only, first adding a hint where appropriate (in a translatable way, I believe), then making a new subroutine to check for this.

Marking Passed QA
Comment 8 Paul Poulain 2012-06-09 10:36:35 UTC
more a tiny ENH than a bugfix, but chris_c, I let you decide.
Comment 9 Chris Cormack 2012-06-10 09:26:16 UTC
Pushed to 3.8.x, will be in 3.8.2