If you add or edit a currency with an exchange rate other than "1.0" the "active" checkbox is disabled, but the interface does not explain why. It would be nice to have a hint by the input explaining why it is disabled.
Created attachment 9638 [details] [review] Bug 8119 - Show hint when disabling active currency checkbox Display a hint when the exchange rate != 1.0: "The active currency must have a rate of 1.0"
Created attachment 9657 [details] [review] Bug 8119 - Show hint when disabling active currency checkbox Display a hint when the exchange rate != 1.0: "The active currency must have a rate of 1.0" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 9692 [details] [review] Bug 8119 - Followup: Show hint when disabling active currency checkbox Display the message on editing
Created attachment 9927 [details] [review] Bug 8119 - Show hint when disabling active currency checkbox Display a hint when the exchange rate != 1.0: "The active currency must have a rate of 1.0" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Created attachment 9928 [details] [review] Bug 8119 - Followup Show hint when disabling active currency checkbox Display the message on editing Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed off by Shari Perkins, uploaded with Jared Camins-Esakov's account.
Both patches are javascript-only, first adding a hint where appropriate (in a translatable way, I believe), then making a new subroutine to check for this. Marking Passed QA
more a tiny ENH than a bugfix, but chris_c, I let you decide.
Pushed to 3.8.x, will be in 3.8.2