Bug 8124 - Hide option to download results of items with no checkouts report
Summary: Hide option to download results of items with no checkouts report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P3 normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-18 14:51 UTC by Owen Leonard
Modified: 2013-12-05 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8124 - Hide option to download results of items with no checkouts report (1.78 KB, patch)
2012-05-18 14:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8124 - Hide option to download results of items with no checkouts report (1.80 KB, patch)
2012-05-19 09:28 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-05-18 14:51:09 UTC
In the template of the "Items with no checkouts" report:

<li><label for="outputfile">To a file: </label><input type="radio" name="output" value="file" id="outputfile" disabled="disabled" /><!-- FIXME: Not implemented -->

That FIXME has been there forever. The option should be hidden until someone actually fixes it.
Comment 1 Owen Leonard 2012-05-18 14:54:50 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-05-19 09:28:52 UTC
Created attachment 9653 [details] [review]
Bug 8124 - Hide option to download results of items with no checkouts report

We should not show disabled controls for features which don't work.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Jonathan Druart 2012-05-22 08:59:02 UTC
QA Comments:
Ergonomic changes.
Hide a not implemented feature.
Passed QA
Comment 4 Chris Cormack 2012-05-28 09:34:59 UTC
Pushed to 3.8.x, will be in 3.8.2