We would like a feature that allows librarians to attach unlimited arbitrary files to a patron record. Specifically, we want to store a PDF document with a patron record. They would be like the patron images, but for a document. We would like a link on the patron record that when clicked would open the PDF.
Created attachment 9684 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Created attachment 9685 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Created attachment 9858 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Trying to sign off on this patch using Biblibre's sandbox. Got the message below <h1>Something went wrong !</h1>Applying: Bug 8130 - attach PDF files to a patron record<br/> Using index info to reconstruct a base tree...<br/> Falling back to patching base and 3-way merge...<br/> Auto-merging installer/data/mysql/sysprefs.sql<br/> CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql<br/> Auto-merging installer/data/mysql/updatedatabase.pl<br/> CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl<br/> Failed to merge in the changes.<br/> Patch failed at 0001 Bug 8130 - attach PDF files to a patron record<br/>
Created attachment 10147 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Created attachment 10173 [details] [review] bug 8130: remove merge marker
Works fine, except there does not seem to be any delete function. Either add delete function or change remit to not include a delete function and add a new bug for delete capability.
Created attachment 10176 [details] [review] Bug 8130 - Fix incorrect permission, allow deletion of files of logged in user has 'borrowers' permission
Created attachment 10177 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Squashed all patches together for ease of use.
Created attachment 10185 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file.
Patch does not apply; probably a merge conflict in updatedatabase
Created attachment 10312 [details] [review] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. Signed-off-by: Liz Rea <wizzyrea@gmail.com> rebased for current master.
Further rebasing has been required... This all looks very good, except I'm not terribly thrilled about the hardcoded MAX_FILE_SIZE value in the upload. It seems to me that that value should be controllable by the sysadmin, rather than locked in at 2000000. I think a followup fix would be appropriate here, rather than a complete resubmission. Rebased version is Passed QA.
Created attachment 10419 [details] [review] [PASSED QA] Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. Signed-off-by: Liz Rea <wizzyrea@gmail.com> rebased for current master. Signed-off-by: Ian Walls <koha.sekjal@gmail.com> rebased again; some indentation issues in include menus.
Hi Melia, Could you explain the use case for this feature ? I can't see why it's something we would need in an ILS.
Hi Paul, the use case that comes to my mind are signed registration forms or other forms that need a signature from the patron.
Yes, that's exactly it, Katrin.
Patch pushed, but I think it would be usefull to have the list of attached files available on the moremembers.pl page (and maybe also on the check-out page) The use case that has been given make interesting for a librarian to see quickly if there are files attached to ask for missing ones. Exemple: I'm supposed to give a proof of address every year. On the check-out page, when my card is entered, Koha display "Patron Paul Poulain, currently 0 issues, 1 file attached (10/01/2010) => I haven't updated my proof of address (that's just an example) However : the moremember.pl page is really crapy now and would not deserve a large update. But that's another topic !
In bug 7955, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955#c21, Nicole spotted that the "notices" tab appear twice. This was due to the fact that this patch add the "notices" tab without removing it. Probably a rebase mistake. Will push a patch removing the duplicate tab now
Created attachment 10757 [details] [review] Bug 8130 [FOLLOW-UP] attach PDF files to a patron record Markup corrections: - Hide table of files if no files are attached - Move error messages out of table (invalid) - Add <tr> tags to table (invalid) - Apply standard form structure to upload form - Add proper labels and ids to upload form - Correct unescaped ampersands
In testing my patch I found that I couldn't trigger any error messages to appear. The error box appears without text if I submit the form without selecting a file. The error box does not appear at all if I submit a 0-byte file (which I assume is what errors.empty_upload is about?)
Created attachment 11001 [details] [review] [PASSED-QA][SIGNED OFF]Bug 8130 [FOLLOW-UP] attach PDF files to a patron record Markup corrections: - Hide table of files if no files are attached - Move error messages out of table (invalid) - Add <tr> tags to table (invalid) - Apply standard form structure to upload form - Add proper labels and ids to upload form - Correct unescaped ampersands Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment on attachment 11001 [details] [review] [PASSED-QA][SIGNED OFF]Bug 8130 [FOLLOW-UP] attach PDF files to a patron record Passed QA for this patch.
Created attachment 11003 [details] [review] Bug 8310: Followup errors must be a hashref I tested the previous patch and a problem occured. Errors are not displayed. This patch fixes the problem if there is no file uploaded. But if the uploaded file is empty: length($uploaded_file) returns 5 and the error is not displayed.
Created attachment 11006 [details] [review] Bug 8310: Followup - Empty file upload error never displays.
Created attachment 11007 [details] [review] [SIGNED-OFF} Bug 8310: Followup: errors must be a hashref http://bugs.koha-community.org/show_bug.cgi?id=8130 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 11008 [details] [review] Bug 8310: Followup - Empty file upload error never displays. Reuploaded to correct the order of the files to be applied.
Created attachment 11009 [details] [review] Bug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays. http://bugs.koha-community.org/show_bug.cgi?id=8130 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 11010 [details] [review] [SIGNED-OFF] Bug 8130: Followup: errors must be a hashref correct the bug number (8130 not 8310...)
Qa seems easy for the 2 last patches
follow-ups pushed