Bug 8140 - Error when exporting label xml
Summary: Error when exporting label xml
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 11:43 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8140 - Error when exporting label xml (837 bytes, patch)
2012-05-23 11:44 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8140 - [SIGNED-OFF] Error when exporting label xml (913 bytes, patch)
2012-05-25 13:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-05-23 11:43:52 UTC
There is an error in label-create-xml.pl:
Global symbol "@label_ids" requires explicit package name at labels/label-create-xml.pl line 40.
Global symbol "@label_ids" requires explicit package name at labels/label-create-xml.pl line 45.
Global symbol "@label_ids" requires explicit package name at labels/label-create-xml.pl line 45.
Global symbol "@label_ids" requires explicit package name at labels/label-create-xml.pl line 56.
Global symbol "@label_ids" requires explicit package name at labels/label-create-xml.pl line 61.
Comment 1 Kyle M Hall 2012-05-23 11:44:48 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-05-25 13:23:00 UTC
Created attachment 9778 [details] [review]
Bug 8140 - [SIGNED-OFF] Error when exporting label xml

It appears that the name of a variable was changed,
but the declaration of said variable was not.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 3 Paul Poulain 2012-05-28 16:15:30 UTC
QA comment: tiny & trivial patch, passed QA. Just upgrading severity !
Comment 4 Paul Poulain 2012-05-28 16:18:06 UTC
Why did I missed this bug when i've pushed bug 6679 ? I usually "perlcritic xxx", it should have been detected ! will remain mysterious !!! However, thanks Kyle for spotting & fixing
Comment 5 Chris Cormack 2012-06-01 20:05:45 UTC
Pushed to 3.8.x, will be in 3.8.2