Bug 8150 - Patron circulation history has a fossil navagation bar
Summary: Patron circulation history has a fossil navagation bar
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Colin Campbell
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 16:07 UTC by Colin Campbell
Modified: 2013-12-05 19:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.16 KB, patch)
2012-05-24 16:13 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history (1.46 KB, patch)
2012-05-25 07:42 UTC, Magnus Enger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2012-05-24 16:07:15 UTC
The patron circulation history has  new table navigation using datatables but the old navigation is still included in the template so that it appears with two navigation bars one that works and one that doesnt remove the duff one
Comment 1 Colin Campbell 2012-05-24 16:13:04 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2012-05-25 07:42:27 UTC
Created attachment 9770 [details] [review]
Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history

The navigation bar is now supplied by the datatables plugin
however we are still calling the old navigation include
resulting in a second navigation bar which does nor work

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised, without introducing any bad side effects that
I can see.
Comment 3 Paul Poulain 2012-05-28 14:26:35 UTC
QA comment: removal of code only, always ++ ;-)
Comment 4 Paul Poulain 2012-05-28 14:28:26 UTC
Yikes: for an unknown reason, your patch had 2 UTF-8 headers:
  6 Content-Type: text/plain; charset=UTF-8
  7 Content-Transfer-Encoding: 8bit
  8 Content-Type: text/plain; charset="utf-8"


Removing the one from line 8 make the patch working. Magnus, if you can explain why...
Comment 5 Chris Cormack 2012-05-29 04:19:41 UTC
Bug fix, pushed to 3.8.x will be in 3.8.2
Comment 6 Magnus Enger 2012-05-29 08:15:35 UTC
(In reply to comment #4)
> Yikes: for an unknown reason, your patch had 2 UTF-8 headers:
>   6 Content-Type: text/plain; charset=UTF-8
>   7 Content-Transfer-Encoding: 8bit
>   8 Content-Type: text/plain; charset="utf-8"
> 
> 
> Removing the one from line 8 make the patch working. Magnus, if you can
> explain why...

I have no idea why that happens, but I have seen it happen for others too...
Comment 7 Colin Campbell 2012-06-01 13:23:54 UTC
Could be that one is being added due to something in .gitconfig or in a git hook but that the mailer is setting it too....