The patron circulation history has new table navigation using datatables but the old navigation is still included in the template so that it appears with two navigation bars one that works and one that doesnt remove the duff one
Created attachment 9764 [details] [review] Proposed Patch
Created attachment 9770 [details] [review] Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history The navigation bar is now supplied by the datatables plugin however we are still calling the old navigation include resulting in a second navigation bar which does nor work Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, without introducing any bad side effects that I can see.
QA comment: removal of code only, always ++ ;-)
Yikes: for an unknown reason, your patch had 2 UTF-8 headers: 6 Content-Type: text/plain; charset=UTF-8 7 Content-Transfer-Encoding: 8bit 8 Content-Type: text/plain; charset="utf-8" Removing the one from line 8 make the patch working. Magnus, if you can explain why...
Bug fix, pushed to 3.8.x will be in 3.8.2
(In reply to comment #4) > Yikes: for an unknown reason, your patch had 2 UTF-8 headers: > 6 Content-Type: text/plain; charset=UTF-8 > 7 Content-Transfer-Encoding: 8bit > 8 Content-Type: text/plain; charset="utf-8" > > > Removing the one from line 8 make the patch working. Magnus, if you can > explain why... I have no idea why that happens, but I have seen it happen for others too...
Could be that one is being added due to something in .gitconfig or in a git hook but that the mailer is setting it too....