my ( $builterror,$builtquery,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$stopwords_removed,$query_type) = buildQuery(\@operators,\@operands,\@indexes,@limits,\@sort_by,undef,undef); Which is roughly line 75 of addbooks.pl likely should have a \ on the @limits. Because C4::Search.pm around line 1044 shows the parameters being treated the same. I was hoping this would solve my Lingua::Stem::Snowball error, but I will have to continue to hunt deeper.
I was looking originally at 3.6.3. I downloaded 3.8.1 and confirmed this bug exists in it as well.
Created attachment 10564 [details] [review] Added a missing dereference marker for an array parameter. As our library has been adding and editing lots of items, I have yet to see the bug resurface. I think the patch is self-evident.
Created attachment 10576 [details] [review] Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 10606 [details] [review] Bug 8172: Followup: Removes useless empty params QA Comment, Your patch is good, but I think this one adds more readability (It removes empty params passed to buildQuery). On the way, I replace an undefined variable ($debug with $DEBUG) in C4/Search.pm (introduces by the same commit 59f31b98361046af37646485f652f70e16a2e206, Bug 4116). Switch back to need signed off
Created attachment 11372 [details] [review] Bug 8172: Followup: Removes useless empty params Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Simple patch, Marked as Passed QA
Pushed to 3.8.x will be in 3.8.4
Pushed to master today. Already in stable, so status set accordingly