Bug 8177 - Correct a double declaration of variable in Addreturn subroutine
Summary: Correct a double declaration of variable in Addreturn subroutine
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.8
Hardware: All All
: P3 normal (vote)
Assignee: Koha Team University Lyon 3
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 12:24 UTC by Koha Team University Lyon 3
Modified: 2013-12-05 19:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Correct double declaration of variable $type in Addreturn (1005 bytes, patch)
2012-06-01 12:24 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2012-06-01 12:24:58 UTC
Created attachment 9876 [details] [review]
Correct double declaration of variable $type in Addreturn

variable "$type" was declared twice in Addreturn
(Circulation.pm module, line 1631)
Comment 1 Chris Cormack 2012-06-01 20:06:13 UTC
Applying: Correct double declaration of variable in Addreturn
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Correct double declaration of variable in Addreturn
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 2 Katrin Fischer 2012-06-09 16:43:14 UTC
I checked the code on current master and the problem seems to be resolved there. Marking the patch resolved for this reason.

        if($issue->{'overdue'}){
                my ( $amount, $type, $daycounttotal ) = C4::Overdues::CalcFine( $item, $borrower->{categorycode},$branch, $datedue, $today );
                $type ||= q{};