Adding new patrons with extended attributes shows all values from database as opposed to empty input boxes for attributes available. Bug 5742 changed code in C4/Members/Attributes.pm so that WHERE doesn't work correctly when used without borrowernumber (and it's undef when adding new patron)
Created attachment 9948 [details] [review] Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron
I don't know why I change the behaviour of this routine for Bug 5742. It appears useless and introduced side effect. I put back the code like it was before the batch edit patron patch.
Created attachment 9951 [details] [review] Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron Test scenario: 1. make sure that you have ExtendedPatronAttributes enabled 2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0 (you might need to modify categorycode according to your local config) 3. verify that you get all extended patron attributes in form Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Thanks Jonathan, I intended to fix this myself but was distracted by lunch break :-) Anyhow, least I can do is sign off :-))
It's unclear why the code was changed for bug 5742, as I cannot seem to find a valid situation where we should still get the attributes even without the borrowernumber. As this is a small and clear revision to restore things to the way they behaved before, marking as Passed QA.
bugfix, but consequence of an ENH that will be in 3.10, so no need for this patch in 3.8 I think
There have been no further reports of problems so I am marking this bug resolved.