Bug 8200 - /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl
Summary: /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 15:27 UTC by Mark Tompsett
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8200 - removing misc/translator/update.pl - deprecated file (2.04 KB, patch)
2013-03-24 06:09 UTC, Chris Cormack
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8200 - removing misc/translator/update.pl - deprecated file (2.14 KB, patch)
2013-04-02 13:44 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 8200 - removing misc/translator/update.pl - deprecated file (2.18 KB, patch)
2013-04-07 12:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 8200: Follow up - Removing unused file stats.pl (5.30 KB, patch)
2013-04-07 12:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2012-06-06 15:27:04 UTC
Obviously such a hard coded path is BAD.
However, I was just informed on the IRC channel by jcamins that this is deprecated. In which case, this directory needs to be cleaned up, by at least deleting this file. :)
Comment 1 Chris Cormack 2013-03-24 06:09:05 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-04-02 13:40:26 UTC
Here's the conversation FWIW:

15:09  mtompset    okay, okay... a weirdness got my attention before
                   getting to bed.
15:09  mtompset    use lib '/home/chris/git/koha.git';
15:09  mtompset    in the misc/translator/update.pl program.
15:12  jcamins     mtompset: don't use update.pl.
15:12  jcamins     It's deprecated.
15:12  jcamins     Use translate.
15:13  mtompset    I'm not using it... I was just looking for perl use 
                   statements, to make sure the package lists were up to date.
15:13  jcamins     mtompset: okay, good.
15:13  jcamins     mtompset: definitely a bug, though. I'd report it.
15:13  jcamins     Eventually the script will be removed, I think.
15:14  mtompset    when was it deprecated?
15:15  jcamins     mtompset: not sure, exactly. A while ago.

http://stats.workbuffer.org/irclog/koha/2012-06-06#i_987956
Comment 3 Owen Leonard 2013-04-02 13:44:32 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-04-03 09:49:51 UTC
It seems that misc/translator/stats.pl uses this script.
Should we remove it too?
Comment 5 Katrin Fischer 2013-04-07 12:18:14 UTC
Created attachment 17254 [details] [review]
[PASSED QA] Bug 8200 - removing misc/translator/update.pl - deprecated file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch removes unused file.
Comment 6 Katrin Fischer 2013-04-07 12:19:38 UTC
Created attachment 17255 [details] [review]
Bug 8200: Follow up - Removing unused file stats.pl

Patch removes misc/translator/stats.pl that is no
longer used and references deleted script
update.pl in same directory.
Comment 7 Jared Camins-Esakov 2013-04-07 17:38:25 UTC
This patch has been pushed to master and 3.12.x.