When receiving a shipment you can enter the invoice date. I entered a date in the past and it showed that date after hitting submit, but after I receive one item it changes the date back to today's date instead. The date needs to stay set to what the librarian sets - not change to anything else.
More: http://screencast.com/t/fegwGMZ3WzQ
We had a library reporting this for 3.6.3 - didn't confirm it so far, but the report matches.
Ok, found the problem, patch coming.
Created attachment 10067 [details] [review] Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct
Created attachment 10080 [details] [review] [Signed-off] Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Created attachment 10081 [details] [review] Bug 8201 [SIGNED-OFF] : Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Created attachment 10097 [details] [review] Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Trivial patch. Fixed whitespace and merged signed-offs
QA comment: tiny patch that just replaces datereceived=[% loop_order.invoicedatereceived %] by datereceived=[% invoicedatereceived %] passed QA
Not sure 3.8 is affected, but if it is, then worth pushing it onto stable
From what I can tell 3.8 needs the patch too. Problem is also in 3.6.x too, but we might need slightly different patch, because of booksellerid=[% loop_order.booksellerid %].
Created attachment 10109 [details] [review] [3.6.x] Bug 8201: Receive date not passed through correctly
Created attachment 10119 [details] [review] [3.6.x] Bug 8201: Receive date not passed through correctly Separate patch for 3.6.x because variable name got changed between versions. (supplieried instead of booksellerid) Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Pushed to 3.8.x will be in 3.8.2
This patch will be in 3.6.6.