The OPAC authority browser used to have several boxes for the different types of authority searches that are possible. This was confusing to users, and rather ugly. However, the additional options were useful for libraries with massive authority files. I propose adding a dropdown to the authority search page on the OPAC which can be easily hidden using CSS, but offers the option to choose whether to look in main entries, headings, or anywhere.
Created attachment 10266 [details] [review] Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' 'match-heading,' and 'see-from' indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. 8. Repeat the search from step 7 with the "in see from heading" option selected, and notice that the results are more specific (at least if the term you are searching for is generic enough to find false positives in keyword searches on current headings)
New search option "in see from headings" does not work for me. Talking to Jared it probably needs a follow-up - failing QA for the moment.
Created attachment 10304 [details] [review] Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get.
Created attachment 10310 [details] [review] Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get.
Created attachment 10315 [details] [review] [SIGNED-OFF] Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Hiding the new options can be done with CSS:
No results for 1=Match. Error 114 in zebra log. No match for Match :-) in bib1.att Needs some attention still
Created attachment 10644 [details] [review] Bug 8206 follow-up: Add Match index to MARC21 record.abs Although the Match index was correctly configured for UNIMARC authorities and MARC21 authorities indexed with DOM, the Match index was inadvertantly removed from the record.abs file for MARC21 authorities at some point. Since the Match index is required to make best use of the new search options, this patch adds it back in.
Back to Signed Off Will be looking soon
Good to see the additional patch. I did an install to ensure that I have all Zebra files and of course (an init) and a reindex. I searched through authorities in opac and staff (hoping to have the same results) and I checked what I did in the zebra log file. And - not unimportant - I chose for grs1 (you tested dom already :-) All this brings me to the following questions: 1 Since not all fields from the framework come back in record.abs, what actually is the promise of "Any"? Note that any is used in OPAC's Keyword and Staff's All Headings. This is confusing to me too.. 2 Even more confusing is that OPAC's All Headings maps to Match, while the staff does not use Match. 3 Staff uses Heading-Main for Search Authorities; OPAC does not use Heading-Main. 4 You also added Match-heading to the config files. I also see it in AuthoritiesMarc.pm. But how/when do I actually use it? The difference between Heading and Heading-Main, as well as Match and Match-heading is unclear to me. From a user point of view, I would recommend searching from most results ("any") to least results ("main entry") in the same Zebra indexes in both OPAC and staff. The current situation (with and without your patch) is confusing. To be consistent, we should use the same terms and same indexes. Although you could argue that we go outside the scope of this report, I like to ask if we could resolve this now too? Parking at Failed QA for discussion/correction etc.
Created attachment 10860 [details] [review] Bug 8206: make authority search indexes consistent This commit makes the search indexes used for search authorities in the staff client and OPAC more consistent by using the Mainentry, Match, and Any indexes for both, and adjusting the labels so that they correctly describe what the indexes do. Note that the Match index was chosen instead of the Match-heading index because Match-heading has the additional attribute of being for phrase searches and exact matches, whereas Match is used for keyword matching, and is more applicable with GRS-1 indexed records (thanks to the well-known limitations of GRS-1 and exact matching of headings).
Marking signed off manually because I didn't remember to use git-bz to do it. Marcel, if you would like another sign off on this, please set this back to Needs signoff. I was unsure whether this should still be considered signed off since the second follow-up is only to address your QA concerns.
Cannot test this properly now. Installation is broken by 8268.
(In reply to comment #12) > Cannot test this properly now. Installation is broken by 8268. Well, will continue here now. Changing status and will hopefully be adding a signoff to the two followup patches.
The three searches in opac and staff now are using the same indexes. That's fine! Unfortunately, this error comes up on some of the searches in opac and staff (especially on Any): Can't call method "data" on an undefined value at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 335 Note that our records should contain an id in 001! And I did an init + a reindex on the complete zebra db. When testing with yaz-client, I get back a number of hits from zebra, but if I want to show a record, it gives: [14] System error in presenting records -- v2 addinfo 'Could not handle record type grs.marcxml.record' And strange enough, I come across a few lines like below in zebra_log (referring not to 14 but 13..): 16:45:48-25/07 zebrasrv(14) [request] Present ERROR 13 2 1+1 If you have additional info, you are welcome ;) What I will do next but later, is init, reindex etc. without these patches. This error may be in master already.. Tested with Zebra 2.0.50 btw.
(In reply to comment #14) > If you have additional info, you are welcome ;) What I will do next but > later, is init, reindex etc. without these patches. This error may be in > master already.. Going further here. Seem to have resolved the zebra problem now while having installed another instance and shifting master..
OPAC seems to work fine. Staff still has one small presentation problem: Results table contains Summary: HASH(0x3cf6b78)
(In reply to comment #16) > OPAC seems to work fine. > Staff still has one small presentation problem: > Results table contains Summary: HASH(0x3cf6b78) This comes from somewhere else, not these 3 patches. But should be fixed, isn't it?
(In reply to comment #17) > (In reply to comment #16) > > OPAC seems to work fine. > > Staff still has one small presentation problem: > > Results table contains Summary: HASH(0x3cf6b78) > > This comes from somewhere else, not these 3 patches. But should be fixed, > isn't it? I am fixing this on another bug, but what is the problem with this patch that caused it to fail QA?
(In reply to comment #18) > I am fixing this on another bug, but what is the problem with this patch > that caused it to fail QA? No problem, but the other bug just obscures test results. Please let me know when that is fixed. I will then finish my test for this one, and upgrade its status. Thanks.
(In reply to comment #19) > (In reply to comment #18) > > I am fixing this on another bug, but what is the problem with this patch > > that caused it to fail QA? Jared, could you please look at bug 8555? Just a quick fix. If you agree, please sign off on it..
Created attachment 11769 [details] [review] [SIGNED-OFF] Bug 8206: Specify index in OPAC authority search
Created attachment 11770 [details] [review] [SIGNED-OFF] Bug 8206 follow-up: Add Match index to MARC21 record.abs
Created attachment 11771 [details] [review] [SIGNED-OFF] Bug 8206: make authority search indexes consistent
QA Comment: With some delay, but looks fine to me. Works well. Tested marc21 dom and grs1. Looked at unimarc grs1. Seems that normarc dom and unimarc dom are not used for authorities.. Passed QA
Jared, While testing dom for this report, I had the following one error during a zebra reindex: 10:47:52-23/08 zebraidx(17048) [warn] Unknown register type: The error does not list the type it refers to. Any idea? Seems not to be related to this report.
Patch pushed to master Agreed the new behaviour is OK. (our idea when updating opac- was to get rid of those terms that students/patrons don't understand. You reintroduce some terms, but it's *much* smoother than the initial version, and a few CSS can always hide that)
This feature is available in Master.