There should be a link to used authority records from the bibliographic details display. This is already done in 5888 for the "normal" display.
Created attachment 11359 [details] [review] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority.
Created attachment 11474 [details] screenshot Hi Jared, features works nicely. Only request I have is a little space between the magnifying glass and the term. I think we are also missing a space between the relator code and the term, but this can go on a separate bug. I love that the icon has a class, so I can hide it if a library doesn't like it: .authlink {display:none;}
Created attachment 11480 [details] [review] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass.
Created attachment 11519 [details] [review] [SIGNED-OFF] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS.
Created attachment 11584 [details] [review] Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Second patch requires an additional signoff.
I like the little icon! Works well, signed off
Created attachment 11591 [details] [review] Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Jared, i get some conflicts applying both patches to master (ce03893) can you rebase, then ping me for QA?
Created attachment 12261 [details] [review] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS.
Created attachment 12262 [details] [review] Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(In reply to comment #8) > > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> patch looks good, passing QA… $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit ce03893) * f0af280 Bug 8210: add links to authorities in normal mode headings C4/Biblio.pm koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt * 2a60d49 Bug 8210: add links to authorities to headings in OPAC koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl * C4/Biblio.pm OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt OK * koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl OK
Patch pushed to master I don't understand why you say: Because UNIMARC handles authorities differently, the link is not added to the XSLT. In UNIMARC, the $9 also contains the authority. The templates <xsl:template name="tag_7xx"> and <xsl:call-template name="tag_subject"> in UNIMARCslimUtils.xsl could be used for that unless I'm missing something. Your opinion ? (& follow-up welcomed ;-) )