The "Cancel All" button on the Holds Over tab currently cancels all holds over and all holds waiting. This doesn't make sense - librarians are inadvertently canceling all of their holds that are waiting to be picked up. The "Cancel All" button should cancel only the holds over that do not need to be transferred (these are the ones that are older than ReservesMaxPickUpDelay). It should not cancel the holds waiting.
Related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039
I'm not sure if this needs a separate bug entry, but can there also be a confirmation pop-up? "Are you sure you want to do this?"
Hm, I can't think of a situation a library wants to delete all holds (maybe not inventive enough today). I think normally you only want to cancel the expired holds - so it would make sense to me for the button to do that. Maybe the description could be more clear?
They don't really need an "Are you sure you want to do this?" message if the button were working correctly. I can't think of any situation in which a library would want to cancel all of their holds waiting either. The button needs to cancel all of the holds over (which are past the ReserveMaxPickUpDelay anyway), and it should have no effect on the holds waiting.
Created attachment 12623 [details] [review] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting
Test Plan: 1) Create two holds, and set them to waiting for two patrons. 2) Make the waitingdate for one of the holds longer than the value set in ReservesMaxPickUpDelay. 3) You should now see one reserve on each tab on waitingreserves.pl 4) Backup your database 5) On the "Holds over" tab, click 'Cancel all'. This should cancel both holds 6) Restore your database 7) Apply this patch 8) Repeat step 4, only the hold in the "Holds over" tab should be canceled.
Created attachment 12837 [details] [review] [Signed off] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
I applied this patch and followed the test plan above. Before the patch, when I clicked "cancel all" both my holds over and holds waiting were cancelled. After the patch, when I clicked "cancel all" only the holds over were cancelled. I think this patch is working, and I will add my sign-off. I am leaving the status as "needs sign-off" - we need a second sign-off from a non-ByWater staff member, please.
Created attachment 12875 [details] [review] Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment: * 2 signoffs, great * passes koha-qa.pl * no side effect risk I can imagine, script related only to waitingreserves.pl passed QA
Patch pushed to master
Pushed to 3.8.x will be in 3.8.7