Bug 8264 - local cover images not working in IE8
Summary: local cover images not working in IE8
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: David Cook
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 11:43 UTC by Nicole C. Engard
Modified: 2013-12-05 20:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
local image showing in ff (154.99 KB, image/png)
2012-06-18 11:43 UTC, Nicole C. Engard
Details
opac detail in ie8 (63.87 KB, image/png)
2012-06-18 11:43 UTC, Nicole C. Engard
Details
ie8 search (320.09 KB, image/jpeg)
2012-06-18 11:44 UTC, Nicole C. Engard
Details
Bug 8264 - local cover images not working in IE8 (3.58 KB, patch)
2013-04-15 01:22 UTC, David Cook
Details | Diff | Splinter Review
Bug 8264 - local cover images not working in IE8 [ prog ] (3.64 KB, patch)
2013-04-19 14:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 8264 - local cover images not working in IE8 [ prog ] (3.84 KB, patch)
2013-04-27 10:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-06-18 11:43:28 UTC
Created attachment 10350 [details]
local image showing in ff

Local cover image thumbnails are not showing in IE8.  Same search displays in
Firefox.

In IE, images only show at bottom of OPAC Details page.
Comment 1 Nicole C. Engard 2012-06-18 11:43:48 UTC
Created attachment 10351 [details]
opac detail in ie8
Comment 2 Nicole C. Engard 2012-06-18 11:44:06 UTC
Created attachment 10352 [details]
ie8 search
Comment 3 David Cook 2013-04-15 01:22:19 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-04-19 07:43:40 UTC
Would like to test this, but don't have access to any computers running IE, so could someone else please?
Comment 5 Kyle M Hall 2013-04-19 14:03:38 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2013-04-19 14:04:52 UTC
This patch works, but only for the prog theme. Another patch needs to be submitted for the ccsr theme.
Comment 7 Katrin Fischer 2013-04-27 10:47:39 UTC
Created attachment 17749 [details] [review]
[PASSED QA] Bug 8264 - local cover images not working in IE8 [ prog ]

Edmund, rather than myself, was the author of this patch,
so I'm not entirely sure about his code choices, but...it
looks like IE must process images differently than other
browsers.

It seems to me that the images are not appearing in IE,
because they're being regarded as incomplete or having
0/NULL natural width.

This patch simply introduces a try/catch hack where it
tries to add the image and remove any "no-image" elements
even nwhen the image is considered incomplete/width of
0/NULL. It won't do this if it catches any errors,
although I'm not sure that any errors would be caught
with this set up anyway...

It's certainly not the ideal solution, but it's a solution.

To Test:

Before applying the patch:
1) Use IE and FF/Chrome/other browser to view a record
   with local images attached
2) Note that the local images appear in FF/Chrome/other,
   but not in IE

Apply patch.

After applying the patch:
1) Repeat step 1 from above
2) Note that the local images now appear in all browsers
   as they should.

--

As I mentioned before, this seems like a real suboptimal
solution. Any ideas on why IE might be considering local
images to be incomplete or having 0/NULL natural width?

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I did a regression test using Chromium and Firefox in
Ubuntu. I checked both prog and CCSR - covers displayed
nicely.
All tests and QA script pass.
Comment 8 Katrin Fischer 2013-04-27 10:50:15 UTC
Hi David,

looking at your patches the long lines give me some trouble, please take a look here for next time:

http://wiki.koha-community.org/wiki/Commit_messages
Ideally we are shooting for a subject which is 50 characters or fewer, and the body of commit messages should be wrapped at 72 characters. A good blog post on this topic can be found at http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
Comment 9 Jared Camins-Esakov 2013-05-01 10:22:25 UTC
This patch has been pushed to master and 3.12.x.
Comment 10 Chris Cormack 2013-05-08 07:39:27 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13