Created attachment 10390 [details] sort error When you're on the patron's circulation history in the staff client the far right column is sorting by month/day in descending order, but year is ascending.
Can you retest this? I think the patch associated with bug 8017 has fixed by removing some of the sorting layers that were over-complicating. It seems ok in my test.
Actually I can reproduce it... When there are items checked out it ceases sorting by date and searches by string to accomodate the text 'Checked out'. If borrower has no current issues its correct.
Can you retest this? The handling of date sorting has changed since the last comment was added so I'm not sure if this bug is still valid.
On an admittedly small sample dates look ok. Strange behaviour with checked out items .... they always sort as being the earliest if you sort on that column (the sorting value is set to '00-00-0000' The patron's history is more intuitive, these appear as 'checked out' and characters being > numbers always sort as newer. If folk agree that making the two screens consustent is a good idea, I'll submit the patch
Created attachment 37406 [details] [review] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc).
Created attachment 37847 [details] [review] [SIGNED-OFF] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 38141 [details] [review] [PASSED QA] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38142 [details] [review] Follow-up: Remove stry </td> Removes an additional </td> tag that isn't needed.
Patches pushed to master. Thanks Jonathan!