Created attachment 10432 [details] serial without enumeration - all issues look the same When placing a hold on a specific copy we need to show the enumeration or else when it's a serial you're placing a hold on you can't tell which issue you want to place the hold on ...
Hm, this is a pretty serious problem when you allow users to place holds on serial issues. And I thought that this also worked at some point in time because we have a library doing just that. Will have to investigate.
Created attachment 17422 [details] [review] Bug 8294: Fix display of serial enumeration for OPAC holds It turns out that this was not a missing but a broken feature. This patch corrects the template variables to make enumchron show up on the item table for item level holds in the OPAC. To test: Try to place item level holds on 1) a record where at least one item 2) a record where none of the items has items.enumchron information. The column with enumchron should only show for 1), but not for 2).
Created attachment 17433 [details] [review] [SIGNED OFF] Bug 8294: Fix display of serial enumeration for OPAC holds It turns out that this was not a missing but a broken feature. This patch corrects the template variables to make enumchron show up on the item table for item level holds in the OPAC. To test: Try to place item level holds on 1) a record where at least one item 2) a record where none of the items has items.enumchron information. The column with enumchron should only show for 1), but not for 2). Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described.
There is no key named itemdata_enumchron for bibitemloo. itemdata_enumchron is set by the perl script as a variable. The issue was introduced by the switch to T::T. Marked as Passed QA.
Created attachment 17595 [details] [review] Bug 8294: Fix display of serial enumeration for OPAC holds It turns out that this was not a missing but a broken feature. This patch corrects the template variables to make enumchron show up on the item table for item level holds in the OPAC. To test: Try to place item level holds on 1) a record where at least one item 2) a record where none of the items has items.enumchron information. The column with enumchron should only show for 1), but not for 2). Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.6