Created attachment 10452 [details] [review] Attaching patch Add Accession no to OPAC Search drop down list.
Actually the patch adds a barcode search. That is not necessarily what a given library calls its accession number
Hi Meenakshi, please remember to tick the "patch" checkbox when uploading a patch or use "git bz". This way the patch can be viewed corrrectly in Bugzilla. I think the description should probably be changed to barcode, because that's what Koha's term for that field. Also we already have a barcode search option in the staff search.
I don't think that "Accession no." is a good label for the search, since -- as Colin noted -- you're actually searching for barcodes. Also, I don't think this belongs in the masthead search for most libraries. Perhaps you would do better to add this option using jQuery?
Created attachment 12163 [details] [review] Attaching the latest patch. Attaching the latest patch.
Created attachment 12319 [details] [review] [SIGNED-OFF] Bug 8302 - Add accesssion number(barcode) to the drop down list in OPAC Search. Files Modified: i)koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc: Test cases: i)select Barcode in drop down list and enter a exist barcode, check the results. ii)select Barcode in drop down list and enter a non-exist barcode, check the results. Signed-off-by: Marc Veron <veron@veron.ch> Works as expected.
Discussion of this and Bug 8778: http://lists.koha-community.org/pipermail/koha-devel/2012-September/038042.html
The "Library Catalog" (default) search option will search quite successfully for an item's barcode (952$p). IMHO, this is redundant. Still, the same functionality can be achieved by a single line of jQuery placed into opacuserjs $("select[name='idx']").append("<option value='bc'>Barcode</option>"); Setting the bug status to RESOLVED WONTFIX
(In reply to Indranil Das Gupta from comment #7) > The "Library Catalog" (default) search option will search quite successfully > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > functionality can be achieved by a single line of jQuery placed into > opacuserjs > > $("select[name='idx']").append("<option value='bc'>Barcode</option>"); that solution will not work for a multi-language Koha install so, not resolved?
(In reply to Mason James from comment #8) > (In reply to Indranil Das Gupta from comment #7) > > The "Library Catalog" (default) search option will search quite successfully > > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > > functionality can be achieved by a single line of jQuery placed into > > opacuserjs > > > > $("select[name='idx']").append("<option value='bc'>Barcode</option>"); > > > that solution will not work for a multi-language Koha install > > so, not resolved? I imagine a lot of people don't think it should be added to the masthead search, so I suppose the other alternative would be for them to roll their release with translated templates.
Hi David, thx for thinking about translations. :) Actually, you can do that with a little bit more jQuery, also checking for the selected language. I do that a lot to provide German and English when I add something to the OPAC. I think I agree that we should not add another option to the masthead search, when it's available in advanced search.
(In reply to Katrin Fischer from comment #10) > Hi David, thx for thinking about translations. :) > > Actually, you can do that with a little bit more jQuery, also checking for > the selected language. I do that a lot to provide German and English when I > add something to the OPAC. > > I think I agree that we should not add another option to the masthead > search, when it's available in advanced search. exactly what I would do, so +1
(In reply to Mason James from comment #8) > (In reply to Indranil Das Gupta from comment #7) > > The "Library Catalog" (default) search option will search quite successfully > > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > > functionality can be achieved by a single line of jQuery placed into > > opacuserjs > > > > $("select[name='idx']").append("<option value='bc'>Barcode</option>"); > > > that solution will not work for a multi-language Koha install > > so, not resolved? Does http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302#c10 work for you? :-)
Closing this one out