MT9357 In "Home › Reports › Patrons statistics", for the Patron activity, the "no active" choice doesn't work.
Created attachment 14066 [details] [review] proposed patch TEST PLAN 1) Click on Reports -> Patrons to see the "Patrons statistics" page 2) Setup a request which should have result for both inactive and active patrons. For example, select "Patron category" as row and "Patron gender" as column. 3) Launch the request, then come back and select "active" in the "Patron activity" parameter. Launch the request again, the results should be different, displaying only active patrons. 4) Come back and select "inactive" in the "Patron activity" parameter. Launch the request. The results are empty ! After installing this patch you'll obtain stats for the inactive patrons.
I'm unable to reproduce this issue. I'm using the default patron data, which means many patrons without any activity. When I run the queries the 'active' has no results as expected, and the 'no active' gives me 50 total results. Am I testing this incorrectly?
Following the test plan I get the same results (which appear to be valid) before and after the patch.
Following the test plan, the 4th step (inactive) doesn't work : either "no result" or "504 Gatewat Time Out".
I've just test on a sandbox and the patch seems to work. The last step (select "inactive" in the "Patron activity" parameter) gives me the stats for the inactive patrons.
I can reproduce on the production server of the customer, maybe because of the high amount of data (17k users, 70k old_issues). I confirm the result of the reports is the same before and after the patch (and I cannot reproduce on a local instance). But it seems logical to me to exclude old_issues where borrowernumber is null (deleted patrons), don't you think?
Note that this could certainly be fixed on this specific installation if the nginx timeout is increased.
This bug has been in discussion for almost 4 years. I don't see why a discussion is needed here. According to comments, either the patch fixes a bug or it changes nothing, depending on the database content. Switching back to Needs signoff (patch still applies correctly)
Created attachment 58874 [details] [review] Bug 8306: Patrons statistics, fix for patron activity choice The "inactive" for "patron activity" choice is now effective. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
My test plan: 1. Create a borrower X 2. Check out an item to borrower X 3. Check in the same item 4. Delete borrower X So now, I have an old_issues line with borrowernumber = NULL 5. Go to patron stats, Row = category, Column = library, Patron activity filter = no active ==> no results 6. Apply patch 7. Repeat 5 ==> results!
Created attachment 59873 [details] [review] Bug 8306: Patrons statistics, fix for patron activity choice The "inactive" for "patron activity" choice is now effective. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Adrien!
This patch has been pushed to 16.11.x and will be in 16.11.04.
Pushed to 3.22.x for 3.22.17
Pushed to 16.05.x, for 16.05.10 release