some lines in Koha have a hardcode version, like this... use C4::Output 3.02 which cause a version-mismatch error, like this... C4::Output version 3.02 required--this is only version 3.07.00.049 at review.pl line 33
Created attachment 10483 [details] [review] Bug 8315 - fix 'C4::Output 3.02' errors in Koha modified: opac/opac-ratings-ajax.pl modified: opac/opac-tags.pl modified: tags/review.pl
(In reply to comment #1) > Created attachment 10483 [details] [review] > Bug 8315 - fix 'C4::Output 3.02' errors in Koha i've sent a patch that removes the unneeded '3.02' part only 3 lines are changed
Created attachment 10490 [details] [review] Bug 8315 - fix 'C4::Output 3.02' errors in Koha modified: opac/opac-ratings-ajax.pl modified: opac/opac-tags.pl modified: tags/review.pl Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Bug 7941 introduces issues in some pages. 3 are list in this bug, but others exist. At least: tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows); tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows approval_counts whitelist blacklist is_approved); Marking as Passed QA.
Interesting those use lines have been there since 2008, it's only now we actually have accurate version numbers on our modules that they are causing a breakage. Still they definitely shouldn't be there.
On 3.8.2, I see the following things that use versioning: $ grep -rPe '^\s*use\s+[^\s]+\s+\d' * C4/Creators/Template.pm:use C4::Creators::Profile 1.000000; C4/Creators/Template.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values); C4/Creators/Profile.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values); C4/Patroncards.pm: use C4::Patroncards::Batch 1.000000; C4/Patroncards.pm: use C4::Patroncards::Layout 1.000000; C4/Patroncards.pm: use C4::Patroncards::Lib 1.000000; C4/Patroncards.pm: use C4::Patroncards::Patroncard 1.000000; C4/Patroncards.pm: use C4::Patroncards::Profile 1.000000; C4/Patroncards.pm: use C4::Patroncards::Template 1.000000; C4/Labels.pm: use C4::Labels::Batch 1.000000; C4/Labels.pm: use C4::Labels::Label 1.000000; C4/Labels.pm: use C4::Labels::Layout 1.000000; C4/Labels.pm: use C4::Labels::Profile 1.000000; C4/Labels.pm: use C4::Labels::Template 1.000000; C4/Creators.pm: use C4::Creators::Lib 1.000000; C4/Creators.pm: use C4::Creators::PDF 1.000000; C4/Installer.pm:use C4::Installer::PerlModules 1.000000; C4/Patroncards/Patroncard.pm:use C4::Creators::Lib 1.000000 qw(get_font_types); C4/Patroncards/Patroncard.pm:use C4::Creators::PDF 1.000000 qw(StrWidth); C4/Patroncards/Patroncard.pm:use C4::Patroncards::Lib 1.000000 qw(unpack_UTF8 text_alignment leading box get_borrower_attributes); labels/label-manage.pl:use C4::Creators 1.000000; labels/label-manage.pl:use C4::Labels 1.000000; labels/label-create-csv.pl:use C4::Creators 1.000000; labels/label-create-csv.pl:use C4::Labels 1.000000; labels/label-create-xml.pl:use C4::Creators 1.000000; labels/label-create-xml.pl:use C4::Labels 1.000000; labels/label-print.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates get_all_layouts get_output_formats); labels/label-print.pl:use C4::Labels::Batch 1.000000; labels/label-create-pdf.pl:use C4::Creators 1.000000; labels/label-create-pdf.pl:use C4::Labels 1.000000; labels/label-edit-batch.pl:use C4::Creators 1.000000; labels/label-edit-batch.pl:use C4::Labels 1.000000; labels/label-edit-profile.pl:use C4::Creators 1.000000; labels/label-edit-profile.pl:use C4::Labels 1.000000; labels/label-edit-layout.pl:use C4::Creators 1.000000; labels/label-edit-layout.pl:use C4::Labels 1.000000; labels/label-edit-template.pl:use C4::Creators 1.000000; labels/label-edit-template.pl:use C4::Labels 1.000000; misc/cronjobs/overdue_notices.pl:use Locale::Currency::Format 1.28; opac/opac-ratings-ajax.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); opac/opac-tags.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); patroncards/image-manage.pl:use C4::Creators 1.000000; patroncards/image-manage.pl:use C4::Patroncards 1.000000; patroncards/create-pdf.pl:use C4::Creators 1.000000; patroncards/create-pdf.pl:use C4::Patroncards 1.000000; patroncards/manage.pl:use C4::Creators 1.000000; patroncards/manage.pl:use C4::Patroncards 1.000000; patroncards/manage.pl:use C4::Labels 1.000000; patroncards/edit-template.pl:use C4::Creators 1.000000; patroncards/edit-template.pl:use C4::Patroncards 1.000000; patroncards/edit-layout.pl:use C4::Creators 1.000000; patroncards/edit-layout.pl:use C4::Patroncards 1.000000; patroncards/card-print.pl:use C4::Creators 1.000000; patroncards/card-print.pl:use C4::Labels 1.000000; patroncards/edit-batch.pl:use C4::Creators 1.000000; patroncards/edit-batch.pl:use C4::Patroncards 1.000000; patroncards/print.pl:use C4::Creators 1.000000; patroncards/print.pl:use C4::Patroncards 1.000000; patroncards/edit-profile.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates get_unit_values); patroncards/edit-profile.pl:use C4::Patroncards::Profile 1.000000; tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows); tags/review.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar); tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows approval_counts whitelist blacklist is_approved); tools/manage-marc-import.pl:use C4::Labels::Batch 1.000000;
I would love for this to land in master ASAP because it breaks our production, but I would be also happy with patch with removes all versions as Robin pointed out in comment #6... Should I submit one?
Comment on attachment 10483 [details] [review] Bug 8315 - fix 'C4::Output 3.02' errors in Koha Robin, seems you forgot to obsolete the original patch when you uploaded the signed-off one
This still needs a follow up for all the other version numbers Robin listed
Comment on attachment 10490 [details] [review] Bug 8315 - fix 'C4::Output 3.02' errors in Koha This patch has been pushed
Switching back to "assigned", the patch provided has been pushed, other patches welcomed ! Assigning to Dobrica, as you seem to be motivated by this topic ;-)
First patch pushed to 3.8.x
*** Bug 8344 has been marked as a duplicate of this bug. ***
*** Bug 8354 has been marked as a duplicate of this bug. ***
Created attachment 10801 [details] [review] Bug 8315 - remove use C4::* version This patch touches a lot of code, but basically it removes version information from use C4::* in our code.
Created attachment 10803 [details] [review] Bug 8315 - remove use C4::* version This patch touches a lot of code, but basically it removes version information from use C4::* in our code. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA Comment: Remove the version informations when we use a module. C4::Labels[::*], use C4::Creators::*, C4::Installer::PerlModules, C4::Patroncards[::*], Locale::Currency::Format and C4::Tags Marking as Passed QA
Pushed to 3.8.x will be in 3.8.3
*** Bug 8625 has been marked as a duplicate of this bug. ***