Bug 8324 - Redisplay OPAC list with correct sort after edit
Summary: Redisplay OPAC list with correct sort after edit
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 09:56 UTC by Marc Véron
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8324 - Redisplay OPAC list with correct sort after edit (1.60 KB, patch)
2013-08-12 19:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8324 - Redisplay OPAC list with correct sort after edit (1.61 KB, patch)
2013-08-14 16:28 UTC, Galen Charlton
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2012-06-27 09:56:38 UTC
If you edit a user defined list in Opac, change the sort and then klick 'Save',
the list always is displayed in title order (and not in the selected order).

This is due to the fact that save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults to 'title').

If you go back to lists, choose in the table the list from List name, the param is
correct and the list displays in expected order.

Should be fixed because end users will think that changing the sort order is broken.

Marc
Comment 1 Owen Leonard 2013-08-12 19:13:35 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-08-14 16:28:03 UTC
Created attachment 20348 [details] [review]
Bug 8324 - Redisplay OPAC list with correct sort after edit

If you are viewing the contents of a list, edit it, change the default
sort, and save your list will be redisplayed sorted by title no matter
what default sort you chose. Lists do not automatically sort by their
default sort, they must be opened with the sort parameter.

This patch adds the list's sort parameter to the redirect after editing.

To test, open an existing list in the OPAC which contains items. Click
the "Edit list" link at the top of the list contents view. Change the
default sort to something new. Click "Save." If the list is redisplayed
using the new default sort the patch worked.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Comment 3 Jonathan Druart 2013-08-16 12:19:18 UTC
Quite odd, I cannot reproduce the issue.
Without the patch:
Opac > lists > my list.
The default sort is "title". I am on the list results view and I click on the "Edit list" link. I change the "Sort this list by" value to "author", save.
The results list is sorted by author.

What I miss?
Comment 4 Kyle M Hall 2013-09-06 12:55:36 UTC
(In reply to Jonathan Druart from comment #3)
> Quite odd, I cannot reproduce the issue.
> Without the patch:
> Opac > lists > my list.
> The default sort is "title". I am on the list results view and I click on
> the "Edit list" link. I change the "Sort this list by" value to "author",
> save.
> The results list is sorted by author.
> 
> What I miss?

I too cannot reproduce this bug.

Kyle
Comment 5 Kyle M Hall 2013-09-06 12:58:41 UTC
Marking as Failed QA until we have a resolution for this. Owen, can you retest and let us know if you think this patch is still necessary?
Comment 6 Marc Véron 2014-04-13 09:18:55 UTC
I reported this bug in 2012.

I can no longer reproduce the behaviour on current master (3.15.00.028)

I hope it's OK to set it to RESOLVED WORKSFORME

Marc