There is no 100 authority field plugin. It would be nice to have it.
Many people are asking to this plugin. Can anyone with more UNIMARC knowlegdes than me start this? I can improve the plugin later.
Created attachment 21115 [details] Script to generate UNIMARC authorities 100 field
Created attachment 21116 [details] Template for UNIMARC authorities 100 field
The script needs to be copied to ../intranet/cgi-bin/cataloguing/value_builder/ The template needs to be copied to ../intranet/htdocs/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ I've tested and everything worked fine.
Vitor, looks promising, tested and works well AFAIK. But: 1) You must make a patch a) Verify unimarc_field_100_authorities.pl is chmoded +x b) Update licence information, you do not work for katipo :) read http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence c) do git add cataloguing/value_builder/unimarc_field_100_authorities.pl git add koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt git commit -m "Bug 8334 - Authority UNIMARC 100 field plugin" d) then do git bz attach -e 8334 HEAD or git format-patch origin/master, and upload that as patch 2) But before upload, you must fix the following errors koha-qa -c 1 -v 3 testing 1 commit(s) (applied to dcbe50c 'Bug 10897: remove test for module tha') FAIL cataloguing/value_builder/unimarc_field_100_authorities.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 124) forbidden pattern: tab char (line 119) forbidden pattern: tab char (line 118) forbidden pattern: tab char (line 122) forbidden pattern: tab char (line 117) forbidden pattern: tab char (line 121) forbidden pattern: tab char (line 123) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 326) forbidden pattern: trailing space char (line 187) forbidden pattern: trailing space char (line 372) forbidden pattern: trailing space char (line 321) forbidden pattern: trailing space char (line 213) forbidden pattern: tab char (line 213) forbidden pattern: trailing space char (line 74) forbidden pattern: trailing space char (line 361) forbidden pattern: trailing space char (line 100) forbidden pattern: trailing space char (line 134) forbidden pattern: trailing space char (line 239) forbidden pattern: tab char (line 188) forbidden pattern: tab char (line 187) forbidden pattern: trailing space char (line 106) forbidden pattern: trailing space char (line 45) forbidden pattern: trailing space char (line 389) forbidden pattern: trailing space char (line 124) forbidden pattern: trailing space char (line 205) forbidden pattern: trailing space char (line 393) forbidden pattern: trailing space char (line 354) forbidden pattern: trailing space char (line 334) forbidden pattern: trailing space char (line 405) forbidden pattern: trailing space char (line 149) forbidden pattern: trailing space char (line 315) OK tt_valid OK valid_template 3) Finally, you must add a test plan to the bug description, for example a) Edit authority framework XXX, link subfield 'a' with plugin b) create a new record or edit one c) use plugin d) save 4) Question: Is there a link to valid language codes? that could be a useful.
> d) then do > git bz attach -e 8334 HEAD Sorry, it's git bz attach 8334 HEAD
Hi Bernardo, Sorry but at this point I can't do a patch for this. If anyone could do that I'll be very appreciated. Bernardo, thanks for testing it and give this info.
Vitor, If you do not mind, I'll post a patch on your behalf. Bernardo
Created attachment 21217 [details] [review] Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this.
Thanks Bernardo for the patch :)
Created attachment 21230 [details] [review] Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez Udated License information. This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this.
Patch applied cleanly, go forth and signoff
It works well, I sign off. Mathieu
Created attachment 23228 [details] [review] [PATCH][SIGNED OFF] Bug 8334 - Authority UNIMARC 100 field plugin
I lower a bit priority... Mathieu
Looks good to me, I ask to Stéphane to have a look too.
Bernardo, could you confirm I can delete commented JS code in the tt file?
It works well, I sign off.
Created attachment 23513 [details] [review] Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez Udated License information. This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23514 [details] [review] Bug 8334: Remove commented JS code Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to Jonathan Druart from comment #18) > Bernardo, could you confirm I can delete commented JS code in the tt file? I confirm :-) That code was on the original file submited by Vitor, I suppose taken from a file he used as template. Anyway, if this pass I think an update to UNIMARC frameworks will be needed to link this plugin permanently. Bernardo
I've pushed this to master. Thanks, Vitor! And thanks, Bernardo, for rescuing this kitten. I updated the author attribution in the base patch to use Vitor's name and credit Bernardo for converting it to a testable Git patch.
Patches pushed to 3.14.x, will be in 3.14.2