Reported on Koha mailing list: I can not change the UNIMARC 100 FIELD Language of cataloging. I changed the default "fre" to "chi", I saved it . But I find all 100 FIELD Language of cataloging are "fre" again. Take a look at C4/Biblio.pm module, line 3547: substr( $string, 22, 6, "frey50" ); Check also rebuild_zebra.pl fix_unimarc_100() function.
This should be a system preference. I've done a similar patch to authorities 100 field, where the default language was french to. I can devellop a patch for this, where "frey50" should the default value of the system preference. Cataloguing tab -> Record structure section UNIMARCField100 = "frey50" What you think about this?
Created attachment 13761 [details] [review] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Added a new system preference to set the UNIMARC field 100 default language. The default value for that system preference is 'fre'. Changed Biblio.pm to use the system preference: - if the language is bad filled in the preferences it uses 'fre' as default value - only replaces the language when the field 100 is empty - if the language is filled with the plugin only replaces the positions 25-28 to 'y50'
Created attachment 13883 [details] [review] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Forget to add the system preference to the template.
Created attachment 13897 [details] [review] BUG - Koha forces UNIMARC 100 field code language to 'fre' Changed Charset.pm to use defaultlanguage instead of 'fre'.
Tested and working in version 3.8.5.
Created attachment 15483 [details] [review] [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Added a new system preference to set the UNIMARC field 100 default language. The default value for that system preference is 'fre'. Changed Biblio.pm to use the system preference: - if the language is bad filled in the preferences it uses 'fre' as default value - only replaces the language when the field 100 is empty - if the language is filled with the plugin only replaces the positions 25-28 to 'y50' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 15484 [details] [review] [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Forget to add the system preference to the template. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 15485 [details] [review] [PASSED QA] BUG 8347 - Koha forces UNIMARC 100 field code language to 'fre' Changed Charset.pm to use defaultlanguage instead of 'fre'. http://bugs.koha-community.org/show_bug.cgi?id=8347 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. 1) Check system preference was added correctly: UNIMARCField100Language 2) Change code in preference to be not 'fre'. 3) Catalog a bibliographic record. - check plugin shows new value - check empty field is filled with new value from the plugin - check you can still edit it to be something else
This patch has been pushed to master.
This does not apply on 3.10.x please rebase and submit if you wish it on that branch.
Chris, For me it's fine to only appear in 3.12.