Created attachment 10710 [details] This shows how the tools menu looks when a user is allowed to access some links. When a user is only allowed to access the tools catalog part it's nice to hide "Patron & Circulation" and "Additional Tools" labels as there are no links under them. Attached a screenshot showing how the view looks.
Created attachment 84757 [details] [review] Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed
Created attachment 84767 [details] [review] Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed Signed-off-by: Owen Leonard <oleonard@myacpl.org> The qa tool gives some warnings but I think they can be considered false positives.
Any translation guru's in the house? Will the QA Script failure mentioned here cause a regression of the likes of bug 18675? `forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 48)`
I only added "IF" statements, so I think that should not affect translations as those don't get translated, especially as they are not inside an translated HTML element.
Thanks Katrin :)
Created attachment 84880 [details] [review] Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed Signed-off-by: Owen Leonard <oleonard@myacpl.org> The qa tool gives some warnings but I think they can be considered false positives. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Just done a quick test to check and it looks good to my untrained eye.. Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04.. it's great seeing these old bugs getting some love!
backported to 18.05.x for 18.05.11