Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank
Summary: Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is se...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 14:56 UTC by Kyle M Hall
Modified: 2013-12-05 20:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank (2.69 KB, patch)
2012-07-10 14:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank (2.79 KB, patch)
2012-07-30 15:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8408 - Followup - Fix broken messages. (2.81 KB, patch)
2012-08-03 11:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8408 - Followup 2 - Add reference to renewing items. (1.77 KB, patch)
2012-08-03 11:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8408 - Followup - Fix broken messages. (2.91 KB, patch)
2012-08-11 18:08 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8408 - Followup 2 - Add reference to renewing items. (1.88 KB, patch)
2012-08-11 18:08 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-07-10 14:56:35 UTC
If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message:

Please note: You have more than 0.00 in fines.

This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether.
Comment 1 Kyle M Hall 2012-07-10 14:59:47 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2012-07-30 15:04:37 UTC
Wanted to sign-off, patch does not apply, sorry.
Comment 3 Owen Leonard 2012-07-30 15:26:35 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2012-07-30 15:29:44 UTC
The patch applied fine for me, and works to fix the problem described. Looking at the way that message is constructed makes me worry about its translatability, but that can be addressed in another bug.
Comment 5 Marc Véron 2012-07-30 16:04:05 UTC
Was about to sign off as well :-)
Comment 6 Jonathan Druart 2012-08-01 10:39:04 UTC
This patch fixes the reported issue.

Marking as Passed QA
Comment 7 Paul Poulain 2012-08-01 15:43:39 UTC
More a minor bugfix than an ENH I think, bumping severity
Comment 8 Chris Cormack 2012-08-02 00:04:40 UTC
This changes the behaviour,

Now instead of telling them they are blocked from renewing because they owe over the fine threshold, it just tells them how much they owe.

(which they can see on their user page) So they don't know how much they have to pay to be able to renew again.

I don't know if this is a good thing or not, or to change the behaviour was a conscious decision?
Comment 9 Kyle M Hall 2012-08-03 11:52:28 UTC
(In reply to comment #8)
> This changes the behaviour,
> 
> Now instead of telling them they are blocked from renewing because they owe
> over the fine threshold, it just tells them how much they owe.

This message never told the user they were blocked from renewing, it is the message given if OpacRenewalAllowed is disabled. The previous message was "Please note: You have more than X.XX in fines." I don't think this is radically different.

If you think is should mention renewing items, I can add that.

On another not, it appears that this patch has been pushed to master. I just noticed this patch breaks the OpacRenewalAllowed version of the message. I will write a followup to address this issue.
Comment 10 Kyle M Hall 2012-08-03 11:54:36 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2012-08-03 11:57:55 UTC Comment hidden (obsolete)
Comment 12 Jared Camins-Esakov 2012-08-11 18:08:36 UTC
Created attachment 11555 [details] [review]
Bug 8408 - Followup - Fix broken messages.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 13 Jared Camins-Esakov 2012-08-11 18:08:49 UTC
Created attachment 11556 [details] [review]
Bug 8408 - Followup 2 - Add reference to renewing items.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 14 Jonathan Druart 2012-09-05 13:05:55 UTC
Last patches just change strings.
Marked as Passed QA.
Comment 15 Paul Poulain 2012-09-07 16:42:27 UTC
Follow-up pushed to master
Comment 16 Chris Cormack 2013-04-20 22:15:45 UTC
Released in 3.10.0