If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether.
Created attachment 10750 [details] [review] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. This patch modifies the message to the following: Please note: You currently owe $fines in fines where $fines in the formatted amount the borrower currently owes in fines.
Wanted to sign-off, patch does not apply, sorry.
Created attachment 11200 [details] [review] [SIGNED-OFF] Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ). A user who owes any fines, when logged in to the OPAC will receive the following message: Please note: You have more than 0.00 in fines. This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether. This patch modifies the message to the following: Please note: You currently owe $fines in fines where $fines in the formatted amount the borrower currently owes in fines. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
The patch applied fine for me, and works to fix the problem described. Looking at the way that message is constructed makes me worry about its translatability, but that can be addressed in another bug.
Was about to sign off as well :-)
This patch fixes the reported issue. Marking as Passed QA
More a minor bugfix than an ENH I think, bumping severity
This changes the behaviour, Now instead of telling them they are blocked from renewing because they owe over the fine threshold, it just tells them how much they owe. (which they can see on their user page) So they don't know how much they have to pay to be able to renew again. I don't know if this is a good thing or not, or to change the behaviour was a conscious decision?
(In reply to comment #8) > This changes the behaviour, > > Now instead of telling them they are blocked from renewing because they owe > over the fine threshold, it just tells them how much they owe. This message never told the user they were blocked from renewing, it is the message given if OpacRenewalAllowed is disabled. The previous message was "Please note: You have more than X.XX in fines." I don't think this is radically different. If you think is should mention renewing items, I can add that. On another not, it appears that this patch has been pushed to master. I just noticed this patch breaks the OpacRenewalAllowed version of the message. I will write a followup to address this issue.
Created attachment 11323 [details] [review] Bug 8408 - Followup - Fix broken messages.
Created attachment 11324 [details] [review] Bug 8408 - Followup 2 - Add reference to renewing items.
Created attachment 11555 [details] [review] Bug 8408 - Followup - Fix broken messages. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 11556 [details] [review] Bug 8408 - Followup 2 - Add reference to renewing items. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Last patches just change strings. Marked as Passed QA.
Follow-up pushed to master
Released in 3.10.0