GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. The bug led to really nice plack benchmarks. Unfortunately they were not true.
Created attachment 10759 [details] [review] Bug 8413 Space in call number breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work.
Created attachment 10760 [details] [review] Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work.
Could you use URI::Escape::uri_escape_utf8 instead of regexing, please? Koha already depends on URI::Escape so that would not introduce a new requirement.
Created attachment 10765 [details] [review] [PATCH] Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo.
Created attachment 11397 [details] [review] Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(In reply to comment #5) > Created attachment 11397 [details] [review] > Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> trivial patch, passing QA mason@xen1:~/git/head$ koha-qa.pl * 363e671 Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl misc/load_testing/benchmark_staff.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
In 3.8.x