Bug 8414 - Intranet header toplinks display white rather than blue in < IE8
Summary: Intranet header toplinks display white rather than blue in < IE8
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low major
Assignee: David Cook
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 01:22 UTC by David Cook
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 8414 : Intranet header toplinks display white rather than blue in < IE8 (938 bytes, patch)
2012-07-11 05:36 UTC, David Cook
Details | Diff | Splinter Review
Bug 8414 : Intranet header toplinks display white rather than blue in < IE8 (912 bytes, patch)
2012-07-11 23:15 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8414 - Intranet header toplinks display white rather than blue in < IE8 (955 bytes, patch)
2012-07-20 18:05 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2012-07-11 01:22:11 UTC
#header a.toplinks in staff-global.css has a color property prefixed by a hash. Firefox, Chrome, and IE8+ ignore this property, but any IE lower than IE8 will show the top links in the intranet with a white colour, which makes it nigh impossible to read against the light blue background.
Comment 1 David Cook 2012-07-11 05:36:52 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-07-11 16:51:59 UTC
I would prefer to see this patch remove the line rather than comment it out.
Comment 3 David Cook 2012-07-11 23:15:57 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2012-07-20 18:05:10 UTC
Created attachment 11055 [details] [review]
[SIGNED-OFF] Bug 8414 - Intranet header toplinks display white rather than blue in < IE8

Removes IE7 hash hack which caused head toplinks to display white rather than dark blue against light blue background

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2012-07-20 18:06:42 UTC
I don't have an installation of IE7 handy but this patch is clearly correct and does nothing to change the status quo in any modern browser.
Comment 6 Jonathan Druart 2012-07-23 10:12:03 UTC
QA Comments:

Nothing to add

Marking as Passed QA.

I have not a IE<8
Comment 7 Paul Poulain 2012-07-24 14:51:27 UTC
(In reply to comment #5)
> I don't have an installation of IE7 handy but this patch is clearly correct
> and does nothing to change the status quo in any modern browser.

Nothing to add
Comment 8 Chris Cormack 2012-07-25 03:24:35 UTC
Pushed to 3.8.x, will be in 3.8.4