Suspended holds are showing up in both the holds queue and holds to pull reports.
Created attachment 10771 [details] [review] Bug 8419 - Suspended holds appear on the daily holds queue Suspended holds are showing up in both the holds queue and holds to pull reports. This patch adds to the sql queries such that any hold that is suspended is not selected.
Created attachment 11383 [details] [review] [SIGNED-OFF] Bug 8419 - Suspended holds appear on the daily holds queue Suspended holds are showing up in both the holds queue and holds to pull reports. This patch adds to the sql queries such that any hold that is suspended is not selected. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Before the patch, a title with a single hold, suspended, appeared in the holds queue report. After the patch that hold no longer appeared in the report. I added another hold on that same title, rebuilt the holds queue report, and the new hold appeared. The holds to pull report appears correct as well.
QA Comments: Seems good for me, marking as Passed QA.
Pushed to 3.8.x will be in 3.8.4
Pushed to master. Already pushed to stable, setting status accordingly
This appears to have resurfaced in 3.10.3 Nicole
(In reply to comment #7) > This appears to have resurfaced in 3.10.3 > > Nicole 3.10.4 is the latest release have you tested that? Or 3.10.x itself?
Created attachment 17451 [details] [review] Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue
I have tested and verified that this bug has been reintroduced in both 3.10.x and master. (In reply to comment #8) > (In reply to comment #7) > > This appears to have resurfaced in 3.10.3 > > > > Nicole > > 3.10.4 is the latest release have you tested that? Or 3.10.x itself?
Created attachment 17782 [details] [review] Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17818 [details] [review] [PASSED QA] Bug 8419 - Suspended holds appear on the daily holds queue This bug was reintroduced by the patch for bu 5911: Transport Cost Matrix Test Plan: 1) Place a hold on a record 2) Run build_holds_queue.pl 3) Verify the hold is showing in the holds queue 4) Suspend the hold 5) Re-run build_holds_queue.pl 6) Note the hold is still in the holds queue 7) Apply patch 8) Re-run build_holds_queue.pl 9) Note the hold is no longer in the holds queue Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes test plan and QA script.
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.6