the tool statisticfines.pl (bz 6858) and the hourly loan (bz5549) are not compatible. statisticfines control date_due with this format : AAAA-MM-JJ and hourly loan have change the format date with the hour AAAA-MM-JJ HH:MM:SS so when i want use statisticfines.pl i have this error message datedue_days: Skipping at staticfines.pl line 159. Illegal date specified (year = 0, month = 0, day = 00) at staticfines.pl line 155 Error on date for borrower 4706: Date::Calc::Date_to_Days(): not a valid date at staticfines.pl line 156. date_due: 0000-00-00 00:00:00
Created attachment 11838 [details] [review] Proposed patch Proposed patch. The main change is the use of Koha::DateUtils::dt_from_string to use DateTime objects in fine computing.
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Created attachment 11844 [details] [review] Bug 8420: tool statisticfines.pl and hourly loan Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
> Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> looks good, passing QA... i've changed version from 3.8 to master $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * e0debe5 Bug 8420: tool statisticfines.pl and hourly loan misc/cronjobs/staticfines.pl * misc/cronjobs/staticfines.pl OK
Patch pushed to master Very local fix to a cron job. Even if the patch is written & signed-off by BibLibre, no side-effect risk at all, i've pushed it.
Doesn't apply cleanly to 3.8.x, please supply a patch for it.
Created attachment 12271 [details] [review] Proposed patch (for 3.8.X) Rebased patch for 3.8.X version. Only one existing line is different form master version.
Pushed to 3.8.x, will be in 3.8.5