Bug 8421 - patron images fail when barcode for patron has a +
Summary: patron images fail when barcode for patron has a +
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Elliott Davis
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 22:23 UTC by Elliott Davis
Modified: 2013-12-05 19:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Added a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl (1.78 KB, patch)
2012-07-11 23:37 UTC, Elliott Davis
Details | Diff | Splinter Review
[SIGNED-OFF] Added a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl (1.88 KB, patch)
2012-07-17 17:03 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Davis 2012-07-11 22:23:06 UTC
It appears that the cardnumber is not url encoded when it comes from
patronimage.pl.  Should be a simple fix.
Comment 1 Elliott Davis 2012-07-11 23:37:44 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-07-17 17:03:59 UTC
Created attachment 10909 [details] [review]
[SIGNED-OFF] Added a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl

To Test:

Add a + (or any char that would need to be encoded) to a card number of a patron with an image attached.
Go to member/moremember.pl.
If the patrons image is there, you are golden.

http://bugs.koha-community.org/show_bug.cgi?id=8421
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Paul Poulain 2012-08-02 12:16:58 UTC
QA comment: tiny template-only patch, passed QA
Comment 4 Chris Cormack 2012-08-02 21:48:58 UTC
Pushed to 3.8.x, will be in 3.8.4