Bug 8433 - use English not needed in modules not using English
Summary: use English not needed in modules not using English
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low trivial (vote)
Assignee: Colin Campbell
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 16:10 UTC by Colin Campbell
Modified: 2014-05-26 21:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (2.33 KB, patch)
2012-07-12 16:22 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 8433 Remove unused 'use English' (2.40 KB, patch)
2012-12-21 15:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8433 Remove unused 'use English' (2.44 KB, patch)
2013-01-04 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2012-07-12 16:10:06 UTC
Sip.pm and the Sip/* modules include a 'use English' but none actually use it.

Cleanup usage
Comment 1 Colin Campbell 2012-07-12 16:22:28 UTC Comment hidden (obsolete)
Comment 2 Colin Campbell 2012-12-04 15:54:44 UTC
Changed from enh -> trivial
Comment 3 Kyle M Hall 2012-12-21 15:54:04 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-01-04 13:57:42 UTC
QA Comments:

I did not test this patch.
This patch removes the English module in 5 modules (and 3 commented lines).

Looks good to me.

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-01-04 13:57:56 UTC
Created attachment 14416 [details] [review]
Bug 8433 Remove unused 'use English'

Adding a use English to mosules which dont may
waste a few CPU cycles and bytes of storage
but doesnt add anything to the sum of human happiness

Remove unnecessary use English's
Removed already commented out but equally unnrcessary
use Exporter in same modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-01-08 03:07:16 UTC
Is there a way to test these changes are safe?
Comment 7 Jonathan Druart 2013-01-08 10:15:59 UTC
Jared,

I think the script xt/find-undefined-subroutines.pl could help us here.

I launched it after applying this patch and I found no error previously existing.
Comment 8 Colin Campbell 2013-01-08 10:27:20 UTC
(In reply to comment #6)
> Is there a way to test these changes are safe?

Compling the scripts with strict and warnings enables should indicated if any references remain to entities defined in English.pm
Comment 9 Jared Camins-Esakov 2013-01-13 13:42:27 UTC
This patch has been pushed to master.