When you try to print a basketgroup under Plack, you get a nasty : Can't call method "header" on an undefined value at /home/paul/koha.dev/koha-community/acqui/basketgroup.pl line 271. at /home/paul/koha.dev/koha-community/acqui/basketgroup.pl line 492 The exact same URL under CGI works fine.
Created attachment 10868 [details] [review] Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack
Created attachment 11024 [details] [review] Bug 8439 - plack code cleanup - remove all exit(1) and replace them with __END__ which benefits CGI - insert correct =cut markers at end of POD (required for CGI::Compile under plack to correctly parse source code and exeute it) - scope variables with our which are used inside sub for plack
Created attachment 11030 [details] [review] [SIGNED-OFF] Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
The first patch fixes the problem of printing a basket group and is signed off. The second patch seems to be unrelated to this bug, I have not tested it. I mark this as signed off now so the first patch can go to QA.
Sorry about confusion, second patch was supposed to end up in Bug 8482 - labels creator fixes for plack
QA comment: tiny patch, same as what is made for other patches for Plack
Pushed to 3.8.x, will be in 3.8.4