Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen
Summary: Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup sc...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-16 04:23 UTC by David Cook
Modified: 2013-05-23 06:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen (2.93 KB, patch)
2012-07-16 23:53 UTC, David Cook
Details | Diff | Splinter Review
Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen (3.15 KB, patch)
2012-08-23 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen (3.18 KB, patch)
2012-08-23 16:00 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen (3.21 KB, patch)
2012-10-02 13:51 UTC, Owen Leonard
Details | Diff | Splinter Review
[FOLLOW-UP] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen (1.36 KB, patch)
2012-10-02 13:58 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2012-07-16 04:23:07 UTC

    
Comment 1 David Cook 2012-07-16 23:53:27 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2012-08-09 14:43:19 UTC
Patch doesn't apply anymore

Applying: Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen
Comment 3 Owen Leonard 2012-08-23 15:54:18 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2012-08-23 16:00:13 UTC
Created attachment 11795 [details] [review]
[SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

This patch re-implements and adapts the changes dcook@prosentient.com.au
submitted in a patch which no longer applies. I have changed the
"alert" style messages to "message" style to match the style
which is applied to "hold found" messages elsewhere.

I have also revised the language in a way that I think is more
clear and accurate.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 5 Jonathan Druart 2012-09-19 14:15:40 UTC
String changes only.
Marked as Passed QA.
Comment 6 Paul Poulain 2012-09-28 10:17:03 UTC
Question:

Owen, you replace:
- <p>This hold placed <snip> at the library : <b> [% branchname %] </b>, Please transfer this hold.

by 
+ Please retain this item and check it in to process the hold.

IE: you loose the information of the branch you must transfer it to. Was it intended ?

Woudln't it be better to have
+   <h2>This item is on hold for pick-up at another library ([% branchname %])</h2>

or something like that?
Comment 7 David Cook 2012-10-01 19:18:56 UTC
(In reply to comment #6)
> Question:
> 
> Owen, you replace:
> - <p>This hold placed <snip> at the library : <b> [% branchname %] </b>,
> Please transfer this hold.
> 
> by 
> + Please retain this item and check it in to process the hold.
> 
> IE: you loose the information of the branch you must transfer it to. Was it
> intended ?
> 
> Woudln't it be better to have
> +   <h2>This item is on hold for pick-up at another library ([% branchname
> %])</h2>
> 
> or something like that?


I don't mean to speak for Owen, but the branchname information isn't particularly useful or relevant at this stage. Really, the staff member just needs to know that the item needs to be transferred (rather than shelved at their location), and that they process the transfer by checking in the item. 

Once they check it in, they'll see the branch to transfer it to and have the option of printing a slip, I believe.
Comment 8 Owen Leonard 2012-10-02 13:51:56 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2012-10-02 13:58:15 UTC
Created attachment 12638 [details] [review]
[FOLLOW-UP] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

(In reply to comment #6)
> Question:
>
> IE: you lose the information of the branch you must transfer it to. Was it
> intended ?

I don't recall my reasoning when I submitted the patch but I agree that having the library name is useful.

This follow-up returns the library name to message about hold requiring transfer
Comment 10 Paul Poulain 2012-10-05 08:46:46 UTC
Patch pushed to master
(would it be considered by chris_c as a bugfix I would not object)