Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Summary: Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.10
Hardware: All All
: P1 - high major
Assignee: Mason James
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 02:08 UTC by Mason James
Modified: 2013-12-05 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test (1.01 KB, patch)
2012-07-18 02:10 UTC, Mason James 		Details | Diff | Splinter Review
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test (1.01 KB, patch)
2012-07-18 12:38 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2012-07-18 02:08:11 UTC 
Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Comment 1 Mason James 2012-07-18 02:10:40 UTC Comment hidden (obsolete)
Comment 2 Mason James 2012-07-18 02:13:00 UTC 
(In reply to comment #1)
> Created attachment 10915 [details] [review]
> Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
> 
> modified:   Koha/SearchEngine/Solr/Search.pm


- before patch...
 $ perlcritic Koha/SearchEngine/Solr/Search.pm
 Variable declared in conditional statement at line 41, column 5.  Declare
 variables outside of the condition.  (Severity: 5)
 
- after patch...
 $ perlcritic Koha/SearchEngine/Solr/Search.pm
 Koha/SearchEngine/Solr/Search.pm source OK
Comment 3 Jonathan Druart 2012-07-18 12:38:31 UTC 
Created attachment 10933 [details] [review]
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test

modified:   Koha/SearchEngine/Solr/Search.pm

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Paul Poulain 2012-08-02 14:12:54 UTC 
QA comment: tiny patch just for perlcritic. Fixes perlcritic stuff, so it's OK
Comment 5 Chris Cormack 2013-04-20 11:15:57 UTC 
Released in 3.10.0