As part of the patch introduced by bug 7398 the calculation of priority is governed by the display option. However the if the rank is not calculated because you have not opted to display it undef is passed to AddReserve and holds are not being picked up by subsequent pull lists
Created attachment 11037 [details] [review] Proposed Patch Removes the if related to the syspref perltidied the reindented code For clarity used rank + 1 rather than rank++ then assigning it as incrementing the variable may suggest to the casual reader that rank is used elsewhere rather than just about to cease to exist.
Created attachment 11344 [details] [review] Bug 8479 Calculate rank irrespective of display option Calculation of rank was being skipped based on display option but it is used in calculating the rank passed to AddReserve resulting in reserves being created with null priorities causing them to be skipped in subsequent processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to comment #2) > Created attachment 11344 [details] [review] > Bug 8479 Calculate rank irrespective of display option > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 90dd666 Bug 8479 Calculate rank irrespective of display option opac/opac-reserve.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
Patch doesn't apply cleanly on 3.8.x, if it is needed please submit a patch based on 3.8.x
3.8 does not have the syspref introduced with bug 7398 so should not require this. But will need applying id bug 7398 applied
(In reply to comment #5) > 3.8 does not have the syspref introduced with bug 7398 so should not require > this. > But will need applying id bug 7398 applied Thanks for this Colin.
Released in 3.10.0