After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. It would be very useful to highlight the matches on the details page in the same way we highlight them on the results page.
Created attachment 11210 [details] [review] Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted.
Created attachment 11328 [details] [review] Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 11329 [details] [review] Bug 8525: Followup Don't reset the hz scrollbar to the top Hum... an annoying behaviour exists when we click on the "highlight" or "unhighlight" links: the scrollbar is repositionned to the top. This patch fixes that. Switch to NSO. It's a very quick SO ! :)
Created attachment 11336 [details] [review] Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 11337 [details] [review] Bug 8525: Followup Don't reset the hz scrollbar to the top Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Template only changes (except for the addition of a new template param in the perl file) to allow highlighting on the details page. Marking as Passed QA, both primary and followup.
Patch pushed. Note that this feature has the same problem than the list one : it's diacritic sensible. It means that, if you search "jéan", you'll get result containing "jean" (as expected), but they won't be highlighted.
Created attachment 12595 [details] [review] Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change.
Follow up needs sign off please.
Created attachment 12605 [details] [review] Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Tiny followup for preference description signed off.
Note that the follow-up is a bugfix.
Change syspref description. Last patch marked as Passed QA.
follow-up pushed to master. back to ENH